-
Notifications
You must be signed in to change notification settings - Fork 1
Fix case studies filter search to show hidden tags immediately #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove tag-item--hidden class when showing tags during search - Restore original visibility state when search input is cleared - Read defaultVisibleTagsCount from DOM data attribute for proper state management
WalkthroughThe change updates Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🧬 Code graph analysis (1)website/modules/asset/ui/src/searchInputHandler.js (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Vulnerabilities of
|
| digest | sha256:f67731f1d178283146a4d18d9b9ed30d158620f6e3a09b82f9e9477e994401b9 |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 291 MB |
| packages | 985 |
📦 Base Image node:23-alpine
| also known as |
|
| digest | sha256:b9d38d589853406ff0d4364f21969840c3e0397087643aef8eede40edbb6c7cd |
| vulnerabilities |
Description
| ||||||||||||||||||||||||
Description
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||
Description
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
website/modules/asset/ui/src/searchInputHandler.js(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
website/modules/asset/ui/src/searchInputHandler.js (1)
website/modules/asset/ui/src/index.js (1)
container(31-31)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint
- GitHub Check: security-scan
- GitHub Check: unit-tests
- GitHub Check: e2e-tests
- Fix prettier formatting for function parameters - Resolve no-lonely-if linting error - Replace ternary operator with if/else to comply with no-ternary rule - Remove lazy loading attributes from case studies images
- Move cs_container query outside handler to avoid repeated DOM lookups - Cache defaultVisibleCount value in closure for better performance - Reduce DOM queries from every keystroke to once per handler setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
website/modules/asset/ui/src/searchInputHandler.js(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Anton-88
Repo: speedandfunction/website PR: 223
File: website/modules/asset/ui/src/scss/_cases.scss:1289-1296
Timestamp: 2025-08-29T09:36:15.180Z
Learning: In website/modules/asset/ui/src/scss/_cases.scss, the user Anton-88 prefers to keep position: sticky for the .filter-modal__content despite potential technical concerns, citing the complicated modal structure as the reason.
🧬 Code graph analysis (1)
website/modules/asset/ui/src/searchInputHandler.js (1)
website/modules/asset/ui/src/index.js (1)
container(31-31)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: unit-tests
- GitHub Check: e2e-tests
- GitHub Check: lint
- GitHub Check: security-scan
- Validate parsed value is positive integer before using it - Fall back to 5 for negative numbers, zero, NaN, or undefined - Prevent bug where negative values would hide all tags
Fixes tag search to immediately reveal matching hidden case-study tags by removing tag-item--hidden and clearing display for matches during an active search. When the search is cleared, original visibility is restored: the first defaultVisibleTags items are shown and extras keep tag-item--hidden. defaultVisibleTagsCount is read from .cs_container data-defaultVisibleTags (default 5). Also removed loading="lazy" from partner images.