Fix create_cogtype_picklist with update_or_create for run_key_migrations #7672
+100
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems that the schema config changes in the specify 0039 migration weren't added to the run_key_migration steps when the migration was first created. I added the functions to the pipeline, so now the agent fields in Loan and Gift will get created in the schema config. 
|
| usc.update_paleo_desc, # specify 0033 | ||
| usc.update_accession_date_fields, # specify 0034 | ||
| usc.update_loan_and_gift_agent_fields, # specify 0039 | ||
| usc.update_loan_and_gift_agents, # specify 0039 |
Member
There was a problem hiding this comment.
add components to this as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7660
Update create_cogtype_picklist to use update_or_create with collection and name as the lookup, aligning with the Picklist uniqueness rule. This prevents duplicate insert attempts when a COGTypes picklist already exists with differing attributes and makes the run_key_migrations command fail.
Checklist
self-explanatory (or properly documented)
Testing instructions