Skip to content

Conversation

@kwhuber
Copy link
Contributor

@kwhuber kwhuber commented Jan 13, 2026

Fixes #7494
Fixes #4988

This fix continues a change from pr-7635 to fix a ui issue when a user deletes records through the query builder. Prior to the change, the results header in the returned query would delete records two at a time. This happened because handleDelete was being called twice, hence the need for the deletingRef tracking set.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a query with at least 2 records
  • Delete all the records that show up
  • Verify that the results count decreases by 1 following each removal
  • Verify that the results count is zero and non-negative once all records are deleted

@kwhuber kwhuber added this to the 7.12.0 milestone Jan 13, 2026
@kwhuber kwhuber requested review from a team and grantfitzsimmons January 13, 2026 20:56
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jan 13, 2026
@kwhuber
Copy link
Contributor Author

kwhuber commented Jan 13, 2026

@grantfitzsimmons This pr accounts for the negative issue in addition to the duplicate delete issue. May I close pr-7635 to avoid duplicate fixes?

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create a query with at least 2 records
  • Delete all the records that show up
  • Verify that the results count decreases by 1 following each removal
  • Verify that the results count is zero and non-negative once all records are deleted

Looks good!

01-14_11.34.mp4

@emenslin emenslin requested a review from a team January 14, 2026 17:36
Copy link
Contributor

@Iwantexpresso Iwantexpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create a query with at least 2 records
  • Delete all the records that show up
  • Verify that the results count decreases by 1 following each removal
  • Verify that the results count is zero and non-negative once all records are deleted

nice job!

@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.13.0 Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Count goes down by 2 when deleting only 1 record from 'browse in forms' Querying and deleting all results makes the results show as -1

5 participants