fix(core/link-to-dfn): incorporate data-dfn-for into generated IDs#5283
Draft
marcoscaceres wants to merge 1 commit into
Draft
fix(core/link-to-dfn): incorporate data-dfn-for into generated IDs#5283marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
When a dfn has a data-dfn-for attribute, include the for-context in the generated ID. This produces semantically meaningful IDs like dfn-wall-clock-unsafe-current-time instead of dfn-unsafe-current-time-0 when multiple dfns share the same text but target different interfaces. Closes #4415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4415
Include the data-dfn-for context in generated IDs to produce
meaningful names instead of numeric suffixes when multiple dfns
share the same text.