fix(core/caniuse): use dl markup and CSS Grid layout#5282
Draft
marcoscaceres wants to merge 2 commits into
Draft
fix(core/caniuse): use dl markup and CSS Grid layout#5282marcoscaceres wants to merge 2 commits into
marcoscaceres wants to merge 2 commits into
Conversation
Replaces div-based layout with semantic dl (dt for browser type, dd for browser cells). Switches from flexbox to CSS Grid with auto-fit columns. More info link gets its own row. Closes #4090
The dl's direct children (dt, dd) were being placed as individual grid items, interleaving labels with browser cells instead of grouping them vertically. Wrapping each pair in a div.caniuse-group makes the grid operate on logical groups. Also updates tests to query the new selectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4090
Replace div-based caniuse layout with semantic dl markup and CSS Grid.
Each dt/dd pair is wrapped in a div.caniuse-group for correct grid
column behavior.