Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new pybind11 release to the Spack py-pybind11 package so users can build/install that version via Spack.
Changes:
- Added Spack package version entry for
3.0.2with its SHA256 checksum.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Superseded by #3731 (pr13-python-cext-tools) which includes py-pybind11 3.0.2 along with other C-extension build tool updates. |
|
(Sorry, overactive AI agent close this unintentionally.) |
|
@spackbot run pipeline. |
|
I encountered an error attempting to run the pipeline. DetailsError: <class 'aiohttp.client_exceptions.ContentTypeError'>, 200, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', url='https://gitlab.spack.io/users/sign_in'
Stack trace:
File "/usr/local/lib/python3.9/site-packages/rq/worker.py", line 1643, in perform_job
return_value = job.perform()
File "/usr/local/lib/python3.9/site-packages/rq/job.py", line 1359, in perform
self._result = self._execute()
File "/usr/local/lib/python3.9/site-packages/rq/job.py", line 1396, in _execute
coro_result = loop.run_until_complete(result)
File "/usr/local/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
return future.result()
File "/source/./spackbot/workers.py", line 246, in run_pipeline_task
result = await helpers.post(url, headers)
File "/source/./spackbot/helpers.py", line 211, in post
return await response.json()
File "/usr/local/lib/python3.9/site-packages/aiohttp/client_reqrep.py", line 749, in json
raise ContentTypeError(
|
|
@wdconinc interesting that the branch got called |
Yeah. My fault :-) I realized too late and branch renames kill the PR. |
|
@wdconinc looks like there are several regressions with 3.0.2 that would require to pin the version, e.g. py-torch. |
|
I am not quite happy with the py-torch limit since it is not clear that this will be fixed in 2.10.1... but let's see how far CI gets with this. |
adamjstewart
left a comment
There was a problem hiding this comment.
Thanks for the heads up, I subscribed to the PyTorch pybind11 update PR, will update the recipe when something changes.
franzpoeschel
left a comment
There was a problem hiding this comment.
Looks good for the openPMD bit. Pybind11 v3.0.2 will work again with our next patch release, until then pinning is fine since this is a build-only dependency.
This PR adds
py-pybind11, v3.0.2 (diff). Bugfixes only; no significant changes to pyproject.toml or CMakeLists.txt (minimum version unchanged). This package will be built in CI.