Skip to content

Winrpath: finddllandrename handle importless dlls #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scheibelp merged 1 commit into from
May 29, 2026
+13 −0
Merged

Winrpath: finddllandrename handle importless dlls #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/winrpath.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,22 @@ bool LibRename::FindDllAndRename(HANDLE& pe_in) {
return false;
}

if (rva_import_directory == 0) {
// No import table is valid (e.g. python3.dll which only forwards exports).
FlushViewOfFile((LPCVOID)basepointer, 0);
UnmapViewOfFile((LPCVOID)basepointer);
return SafeHandleCleanup(h_map_object) != 0;
}

DWORD const number_of_sections = coff_header->NumberOfSections;
DWORD const import_section_file_offset = RvaToFileOffset(
section_header, number_of_sections, rva_import_directory);
if (import_section_file_offset == 0) {
std::cerr << "Import table RVA 0x" << std::hex << rva_import_directory
<< " could not be resolved to a file offset.\n";
UnmapViewOfFile((LPCVOID)basepointer);
return false;
}
char* import_table_offset =
static_cast<char*>(basepointer) + import_section_file_offset;
auto* import_image_descriptor =
Expand Down
Loading