winrpath: Ensure pe parsing can handle binaries built for 32 or 64 bit#42
Merged
Merged
Conversation
Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the headers I was using to parse the PE files were macros that defaulted to either 32 or 64 bit structs based on compiler flags. This is incorrect behavior as we need to be parsing with structs that are compatible with the PE file being parsed not the compiler wrapper. Switch the parsing logic to avoid the use of there headers and check the bitness of the binary when extracting RVAs and import table locations.