Skip to content

Comments

Fix Fireworks#91

Open
Nebhay wants to merge 4 commits intospacedriveapp:mainfrom
Nebhay:fix-FIREWORKS
Open

Fix Fireworks#91
Nebhay wants to merge 4 commits intospacedriveapp:mainfrom
Nebhay:fix-FIREWORKS

Conversation

@Nebhay
Copy link
Contributor

@Nebhay Nebhay commented Feb 20, 2026

Fixes #90

UNTESTED AS I DONT HAVE A API KEY

but this fix is just like the NVIDIA fix that worked fine

  • Added Fireworks base URL constant (src/config.rs):
    • Added FIREWORKS_PROVIDER_BASE_URL constant set to https://api.fireworks.ai/inference
  • Added Fireworks provider registration (src/config.rs):
    • Registered Fireworks provider in load_from_env() function (environment variable loading)
    • Registered Fireworks provider in from_toml() function (TOML config file loading)
    • Both use ApiType::OpenAiCompletions API type and the Fireworks base URL

- **Added Fireworks base URL constant** (`src/config.rs`):
  - Added `FIREWORKS_PROVIDER_BASE_URL` constant set to `https://api.fireworks.ai/v1`
- **Added Fireworks provider registration** (`src/config.rs`):
  - Registered Fireworks provider in `load_from_env()` function (environment variable loading)
  - Registered Fireworks provider in `from_toml()` function (TOML config file loading)
  - Both use `ApiType::OpenAiCompletions` API type and the Fireworks base URL
@the-snesler
Copy link

I tested it with my API key and it doesn't appear to work. I'll try to figure out a working fix on my own (removing the trailing /v1 from the URL doesn't fix it either)
WindowsTerminal_6Jcy5hill0

Co-authored-by: Sam <78718829+the-snesler@users.noreply.github.com>
@Nebhay
Copy link
Contributor Author

Nebhay commented Feb 21, 2026

Perfect thank you, i didn't click on the try request in the docs so i didn't see the full url with the /inference part , my bad

@Nebhay
Copy link
Contributor Author

Nebhay commented Feb 22, 2026

Fixed confict caused by gemini being added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fireworks provider broken in v0.1.9 and v0.1.10

3 participants