chore: Fix compiler warnings throughout project#75
Open
jnyecode wants to merge 2 commits intospacedriveapp:mainfrom
Open
chore: Fix compiler warnings throughout project#75jnyecode wants to merge 2 commits intospacedriveapp:mainfrom
jnyecode wants to merge 2 commits intospacedriveapp:mainfrom
Conversation
- used _prefix on unused variables - add `#[allow(dead_code)]` for unused functions (kept in case needed later) - change drops for `let _ =` (dropping a reference does nothing)
Contributor
|
Probably an oversight? You added it in the first comit and deleted the .claude dir/file in the second commit, it would be cleaner to not add it in the first place :) |
Contributor
Author
|
Yeah apologies... Accidentally included the claude settings so second commit fixed the mistake, not intentional 🙏 |
Contributor
|
No worries! Since both commits have their own real changes, you just need to remove the git rebase -i HEAD~2Mark the first commit as git reset HEAD .claude
git commit --amend --no-edit
git rebase --continueThis unstages the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prefix on unused variables#[allow(dead_code)]for unused functions (kept in case needed later)let _ =(dropping a reference does nothing).gitignoreto not include.claude/dir