Skip to content

Comments

chore: Fix compiler warnings throughout project#75

Open
jnyecode wants to merge 2 commits intospacedriveapp:mainfrom
jnyecode:chore/fix-compiler-warnings
Open

chore: Fix compiler warnings throughout project#75
jnyecode wants to merge 2 commits intospacedriveapp:mainfrom
jnyecode:chore/fix-compiler-warnings

Conversation

@jnyecode
Copy link
Contributor

  • used _ prefix on unused variables
  • add #[allow(dead_code)] for unused functions (kept in case needed later)
  • change drops for let _ = (dropping a reference does nothing)
  • update .gitignore to not include .claude/ dir

Chose to keep unused code since I'm new to the project...

- used _prefix on unused variables
- add `#[allow(dead_code)]` for unused functions (kept in case needed later)
- change drops for `let _ =` (dropping a reference does nothing)
@jnyecode jnyecode changed the title Fix compiler warnings throughout project chore: Fix compiler warnings throughout project Feb 20, 2026
@Marenz
Copy link
Contributor

Marenz commented Feb 20, 2026

Probably an oversight?

You added it in the first comit and deleted the .claude dir/file in the second commit, it would be cleaner to not add it in the first place :)

@jnyecode
Copy link
Contributor Author

Yeah apologies... Accidentally included the claude settings so second commit fixed the mistake, not intentional 🙏

@Marenz
Copy link
Contributor

Marenz commented Feb 20, 2026

No worries! Since both commits have their own real changes, you just need to remove the .claude files from the first commit. Easiest way:

git rebase -i HEAD~2

Mark the first commit as edit, then when it stops:

git reset HEAD .claude
git commit --amend --no-edit
git rebase --continue

This unstages the .claude files from commit 1 without deleting them from your disk. The second commit will rebase cleanly — the .claude removal just becomes a no-op while the .gitignore change stays. Then git push --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants