Skip to content

0.0.0-rc.12 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oyeaussie merged 29 commits into from
Mar 6, 2025
Merged

0.0.0-rc.12 #654

oyeaussie merged 29 commits into from
Mar 6, 2025

Conversation

@oyeaussie
Copy link
Contributor

@oyeaussie oyeaussie commented Mar 6, 2025

No description provided.

@oyeaussie
fix issue #640
3cde7d4
@oyeaussie
fix issue #641
cd1c8db
@oyeaussie
issue #640, fix bug with child process hitting the checkProcessIsRunning
f2f8be6
@oyeaussie
minor bug fix for issue #637
2bdd4e0
@oyeaussie
minor fix issue #633
1e71dd0
@oyeaussie
fix issue #642
711562d
@oyeaussie
fix issue #643
38cf944
@oyeaussie
fix issue #644
f8510b7
@oyeaussie
fix issue #645
3151210
@oyeaussie
update #640, fixed some minor bugs.
0e276ce
@oyeaussie
fix issue #646
74dc025
@oyeaussie
minor bug fix for issue #640
06a21de
@oyeaussie
minor bug fix for issue #643
b3c5903
@oyeaussie
minor bug fix for #640
a464189
@oyeaussie
fix issue #648
8927fec
@oyeaussie
fix issue #649
dd5998a
@oyeaussie
update issue #649
b4a6e56
@oyeaussie
update issue #649. Added details of each process to be sent to the cl…
19d21b9 
…ient.
@oyeaussie
fix minor bug #649
5bf2895
@oyeaussie
fix minor bug #649
818e37c
@oyeaussie
update issue #649
f5fcc55
@oyeaussie
Initial commit issue #650
b47ee07
@oyeaussie
update issue #649
bbac370
@oyeaussie
fix issue #651
72abae6
@oyeaussie
fix issue #652. Changed method to include .fileHashes file for views …
37f52fa 
…directory. Fixed incorrect updated_version being populated if the versions are same.
@oyeaussie
fix issue #653
fb8f36d
@oyeaussie
update issue #650. Rewrite the FF method to get relation data increas…
452fe95 
…ing the performance 3x.
@oyeaussie
update issue #650. If index is searched, we do not need to search aga…
705c98d 
…in. Also, added limit to index searches.
@oyeaussie
update issue #650. removed writing of relationship information to fie…
2c63fb7 
…lds.
@github-advanced-security
Copy link

github-advanced-security bot commented Mar 6, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 6, 2025
View reviewed changes
public/core/default/js/footer/core/Baz/BazHelpers.js

if (found) {
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces '"' with itself.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to ensure that the replacement string correctly escapes the double quotes. Instead of using '\"', which is interpreted as just a double quote, we should use '\\\"' to properly escape the double quotes. This change will ensure that the replacement operation correctly replaces double quotes with escaped double quotes.

Suggested changeset 1
public/core/default/js/footer/core/Baz/BazHelpers.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/public/core/default/js/footer/core/Baz/BazHelpers.js b/public/core/default/js/footer/core/Baz/BazHelpers.js
--- a/public/core/default/js/footer/core/Baz/BazHelpers.js
+++ b/public/core/default/js/footer/core/Baz/BazHelpers.js
@@ -118,3 +118,3 @@
                             //eslint-disable-next-line
-                            var data = found[0].replaceAll('\"', '"');
+                            var data = found[0].replaceAll('"', '\\"');
                             //eslint-disable-next-line
EOF
@@ -118,3 +118,3 @@
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');
var data = found[0].replaceAll('"', '\\"');
//eslint-disable-next-line
Copilot is powered by AI and may make mistakes. Always verify output.
public/core/default/js/footer/core/Baz/BazProgress.js

if (found) {
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces '"' with itself.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to correct the escape sequence in the replacement string. Instead of replacing '"' with '\"', we should replace it with '\\"'. This will correctly escape the double quotes in the string.

  • Locate the line where the replacement is happening.
  • Change the replacement string from '\"' to '\\"'.
Suggested changeset 1
public/core/default/js/footer/core/Baz/BazProgress.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/public/core/default/js/footer/core/Baz/BazProgress.js b/public/core/default/js/footer/core/Baz/BazProgress.js
--- a/public/core/default/js/footer/core/Baz/BazProgress.js
+++ b/public/core/default/js/footer/core/Baz/BazProgress.js
@@ -308,3 +308,3 @@
                             //eslint-disable-next-line
-                            var data = found[0].replaceAll('\"', '"');
+                            var data = found[0].replaceAll('"', '\\"');
                             //eslint-disable-next-line
EOF
@@ -308,3 +308,3 @@
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');
var data = found[0].replaceAll('"', '\\"');
//eslint-disable-next-line
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
public/core/default/js/footer/jsFooterCore.js

if (found) {
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces '"' with itself.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to replace the double quotes with an escaped version. This can be done by changing the replacement string from '\"' to '\\"'. This will ensure that double quotes are properly escaped in the string.

  • Locate the line where the replacement is being made.
  • Change the replacement string from '\"' to '\\"'.
  • Ensure that the rest of the code remains unchanged to maintain existing functionality.
Suggested changeset 1
public/core/default/js/footer/jsFooterCore.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/public/core/default/js/footer/jsFooterCore.js b/public/core/default/js/footer/jsFooterCore.js
--- a/public/core/default/js/footer/jsFooterCore.js
+++ b/public/core/default/js/footer/jsFooterCore.js
@@ -3082,3 +3082,3 @@
                             //eslint-disable-next-line
-                            var data = found[0].replaceAll('\"', '"');
+                            var data = found[0].replaceAll('"', '\\"');
                             //eslint-disable-next-line
EOF
@@ -3082,3 +3082,3 @@
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');
var data = found[0].replaceAll('"', '\\"');
//eslint-disable-next-line
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
public/core/default/js/footer/jsFooterCore.js

if (found) {
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces '"' with itself.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to replace the double quotes in the string with an escaped version. This can be done by changing the replacement string from '\"' to '\\"'. This ensures that the double quotes are properly escaped in the resulting string.

Suggested changeset 1
public/core/default/js/footer/jsFooterCore.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/public/core/default/js/footer/jsFooterCore.js b/public/core/default/js/footer/jsFooterCore.js
--- a/public/core/default/js/footer/jsFooterCore.js
+++ b/public/core/default/js/footer/jsFooterCore.js
@@ -12166,3 +12166,3 @@
                             //eslint-disable-next-line
-                            var data = found[0].replaceAll('\"', '"');
+                            var data = found[0].replaceAll('"', '\\"');
                             //eslint-disable-next-line
EOF
@@ -12166,3 +12166,3 @@
//eslint-disable-next-line
var data = found[0].replaceAll('\"', '"');
var data = found[0].replaceAll('"', '\\"');
//eslint-disable-next-line
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@oyeaussie oyeaussie merged commit 8885052 into main Mar 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oyeaussie