Skip to content

0.0.0-rc.7 #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oyeaussie merged 34 commits into from
Jan 31, 2025
Merged

0.0.0-rc.7 #587

oyeaussie merged 34 commits into from
Jan 31, 2025

Conversation

@oyeaussie
Copy link
Contributor

@oyeaussie oyeaussie commented Jan 31, 2025

No description provided.

oyeaussie added 30 commits August 20, 2024 22:39
@oyeaussie
fix issue #564
cefbe3e
@oyeaussie
Update issue #34
e50194f
@oyeaussie
update issue #352
b24b7e2 
- Added .gitignore for apptypes
- Fixed not able to add differnt version to dependency
- Fixed URL for Core and non core modules
- Fixed github link for apptypes
@oyeaussie
update #34
1267fe6 
- Added option to add query only specific repository for a module instead of the whole organization
@oyeaussie
update issue #484
038ecde 
- Cleanup apis generic form/view.
- API client services should only list apis that are available for core in core app_type.
@oyeaussie
update issue #352
3b491e0 
- Fix information displayed on repo create to add all instead of * as we want to include .(dot) files like .gitignore as well.
@oyeaussie
update #34
5803e87 
- Fix not able to grab categories that are camel case.
@oyeaussie
Update #568 & #569
1e3d246 
- Fixed exception for template for timezone component
- Fixed TZ extraction from wikipedia failing.
- Refactored widgets and dashboard components/packages.
- Removed old widgetsserviceprovider as its moved to basepackages.
@oyeaussie
Update #568 & #569
f5bf6f0 
- Removed clocks information from settings and we are going to use timezone package information to obtains clock information.
- Fixed bugs pertaining to extraction of data from wikipedia.
@oyeaussie
Update #568 & #569
6542d8a 
- Fixed permissions for dashboard.
@oyeaussie
Initial commit #570
40e5f43
@oyeaussie
update #569
3746c78
@oyeaussie
fix bug with timer not being stopped after we move away from dashboar…
f68b3d4 
…d worldclock widgets #569
@oyeaussie
update #570
0ea5ba0 
- Added shared for dashboard. added remove for dashboard
@oyeaussie
fix issue #571
2d6be2c
@oyeaussie
update #570
7fe3be9 
- Condition to disallow deletion of app default dashboard.
@oyeaussie
update #573 - geodata to v2.5
d35f259
@oyeaussie
!576 & !577 - Fixed.
445d84f
@oyeaussie
cleanup #576
22e19ea
@oyeaussie
update #34
7299eec 
- Added name, app_type and display name to queue information.
- WIP on installer, refactoring, cleanup.
@oyeaussie
Fix issue #580
cc516fb 
- Added correct encoding for substr
@oyeaussie
update #578
9dc41f2
@oyeaussie
Add queue settings #34
61a022a
@oyeaussie
Fix issue #581
4f441de
@oyeaussie
Fix issue #582
3c074d1
@oyeaussie
update #34
f2b2871
@oyeaussie
update #34
221fd43
@oyeaussie
update #34 test DB update.
75210b4
@oyeaussie
update #34 test DB update
a29fe9e
@oyeaussie
Initial commit for #584.
c7b40bc
@github-advanced-security
Copy link

github-advanced-security bot commented Jan 31, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2025
View reviewed changes
apps/Core/Views/Default/html/dashboards/dashboards.html
Comment on lines +489 to +490
href +
$('#{{componentId}}-{{sectionId}}-dashboards').select2().val()

Check failure

Code scanning / CodeQL

DOM text reinterpreted as HTML High

DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to ensure that the value obtained from select2().val() is properly encoded before being used in the URL. This can be achieved by using a function that encodes the value to make it safe for inclusion in a URL. JavaScript's encodeURIComponent function is suitable for this purpose.

  • We will modify the code to use encodeURIComponent on the value obtained from select2().val().
  • This change will be made on line 490 where the value is concatenated with the href.
Suggested changeset 1
apps/Core/Views/Default/html/dashboards/dashboards.html

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/Core/Views/Default/html/dashboards/dashboards.html b/apps/Core/Views/Default/html/dashboards/dashboards.html
--- a/apps/Core/Views/Default/html/dashboards/dashboards.html
+++ b/apps/Core/Views/Default/html/dashboards/dashboards.html
@@ -488,4 +488,4 @@
                     'href',
-                    href +
-                    $('#{{componentId}}-{{sectionId}}-dashboards').select2().val()
+                    href + 
+                    encodeURIComponent($('#{{componentId}}-{{sectionId}}-dashboards').select2().val())
                 );
EOF
@@ -488,4 +488,4 @@
'href',
href +
$('#{{componentId}}-{{sectionId}}-dashboards').select2().val()
href +
encodeURIComponent($('#{{componentId}}-{{sectionId}}-dashboards').select2().val())
);
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@oyeaussie oyeaussie merged commit bc564f8 into main Jan 31, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oyeaussie