Revert PR #34 (socket fix) — causes continuous reloads on staging#35
Merged
Conversation
This reverts commit fcddd9a.
✅ Deploy Preview for verify-sourcify-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket fix#34 (fixes from \socket fix`), which only bumped transitive packages inpackage-lock.json`.Bumps reverted
Runtime transitives that could affect built output:
bn.js5.2.3 → 5.2.2 (via@ethersproject/bignumber)fast-uri3.1.2 → 3.1.0 (viaajv)Build/dev-only bumps also reverted:
rollup4.59.0 → 4.44.0,postcss8.5.10 → 8.5.6,picomatch4.0.4 → 4.0.2,lodash4.18.0 → 4.17.21.Follow-up
The CVE fixes that
socket fixwas applying should be re-introduced surgically (one package at a time, with a staging smoke test) so we can identify the offending bump rather than ship them as a single batch.Test plan