Skip to content

Do not block lint / format on metaschema failures#152

Merged
jviotti merged 1 commit intomainfrom
metaschema-failures-tolerate
Jan 28, 2026
Merged

Do not block lint / format on metaschema failures#152
jviotti merged 1 commit intomainfrom
metaschema-failures-tolerate

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 28, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the metaschema-failures-tolerate branch from 062aede to 411c5b7 Compare January 28, 2026 17:45
@jviotti jviotti marked this pull request as ready for review January 28, 2026 17:45
@augmentcode
Copy link

augmentcode bot commented Jan 28, 2026

🤖 Augment PR Summary

Summary: This PR removes the “metaschema failure blocks everything” behavior so that linting and format checking still run even when metaschema validation reports errors.

Changes:

  • Removed the blockedByMetaschema flag from the extension↔webview protocol (PanelState).
  • Updated the VS Code extension to stop short-circuiting on metaschema errors and instead run metaschema, lint, and format-check together.
  • Removed UI logic that forced the Metaschema tab / disabled Lint & Format when metaschema failed.
  • Simplified LintTab and FormatTab props by dropping the “blocked” state handling.
  • Adjusted HealthBar behavior to no longer treat metaschema errors as a hard “N/A” health state.
  • Added a VS Code integration test asserting lint diagnostics are still produced even when metaschema validation fails.

Technical Notes: Extension diagnostics now update both lint and metaschema results from a single refresh cycle, allowing lint/format feedback to remain available while metaschema issues are present.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 4c35889 into main Jan 28, 2026
4 checks passed
@jviotti jviotti deleted the metaschema-failures-tolerate branch January 28, 2026 17:50
@jviotti
Copy link
Member Author

jviotti commented Jan 28, 2026

@Karan-Palan Shot it myself now, as I need to release it before tomorrow!

@Karan-Palan
Copy link
Collaborator

Looks good @jviotti

However:

Screencast.from.2026-01-28.23-32-51.mp4

Do I replace it with something like this or the format command output?:

image

@jviotti
Copy link
Member Author

jviotti commented Jan 28, 2026

Ahh good catch. And that's not even a metaschema error though, it is failing to even locate the metaschema. Can you first of all open an issue for this? I believe the metaschema command and others will return a different exit code in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants