lint: add conflicting_readonly_writeonly rule#817
Merged
jviotti merged 1 commit intoMay 18, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: AcE <kintan0108@gmail.com>
AcEKaycgR
force-pushed
the
feat/linter-conflicting_readonly_writeonly
branch
from
5d07f69 to
3265388
Compare
jviotti
approved these changes
May 18, 2026
Member
jviotti
left a comment
jviotti
left a comment
There was a problem hiding this comment.
Super! Impeccable PR! thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new lint rule
conflicting_readonly_writeonlythat fires when a schemahas both
readOnly: trueandwriteOnly: trueset. These keywords aremutually exclusive.
Applies to Draft 7, 2019-09, and 2020-12.
Changes
src/alterschema/linter/conflicting_readonly_writeonly.h- new rulesrc/alterschema/alterschema.cc- rule registered for all three dialectssrc/alterschema/CMakeLists.txt- header addedtest/alterschema/alterschema_lint_draft7_test.cc- tests addedtest/alterschema/alterschema_lint_2019_09_test.cc- tests addedtest/alterschema/alterschema_lint_2020_12_test.cc- tests addedPart of sourcemeta/core#1975.