Enhance ValidExamples linter to preserve valid examples in JSON Schema#497
Open
Karan-Palan wants to merge 5 commits intosourcemeta:mainfrom
Open
Enhance ValidExamples linter to preserve valid examples in JSON Schema#497Karan-Palan wants to merge 5 commits intosourcemeta:mainfrom
Karan-Palan wants to merge 5 commits intosourcemeta:mainfrom
Conversation
…ples Signed-off-by: karan-palan <karanpalan007@gmail.com>
jviotti
reviewed
Aug 22, 2025
jviotti
reviewed
Aug 22, 2025
jviotti
reviewed
Aug 22, 2025
jviotti
reviewed
Aug 22, 2025
jviotti
reviewed
Aug 22, 2025
…r and remove unecessary checks Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the behavior of the
ValidExampleslinter in the Blaze JSON Schema validator. Previously, the linter would remove the entireexamplesarray if any example failed validation. With this enhancement, the linter now selectively removes only the invalid examples while preserving the valid ones.Changes:
ValidExamplesimplementation to track invalid indices and remove only invalid examples.Benefits: