Skip to content

fix: still exit with non-zero when there is an unknown err #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burmudar merged 1 commit into from
May 6, 2026
+16 −11
Merged

fix: still exit with non-zero when there is an unknown err #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions cmd/src/run_migration_compat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,24 @@ func runMigrated() (int, error) {
ctx := context.Background()

err := migratedRootCommand().Run(ctx, os.Args)
if errors.HasType[*cmderrors.UsageError](err) {
return 2, nil
}
if e, ok := err.(*cmderrors.ExitCodeError); ok {
if e.HasError() {
return e.Code(), e
if err != nil {
if errors.HasType[*cmderrors.UsageError](err) {
return 2, nil
}
return e.Code(), nil
}
var exitErr cli.ExitCoder
if errors.AsInterface(err, &exitErr) {
return exitErr.ExitCode(), err
if e, ok := err.(*cmderrors.ExitCodeError); ok {
if e.HasError() {
return e.Code(), e
}
return e.Code(), nil
}
var exitErr cli.ExitCoder
if errors.AsInterface(err, &exitErr) {
return exitErr.ExitCode(), err
}

return 1, err
}

return 0, err
}

Expand Down
Loading