fix/security: prevent command injection on windows#1272
Merged
Conversation
burmudar
reviewed
Mar 10, 2026
burmudar
approved these changes
Mar 10, 2026
burmudar
reviewed
Mar 10, 2026
cbrnrd
approved these changes
Mar 10, 2026
evict
force-pushed
the
vr/security/prevent-command-injection
branch
from
089fa4b to
681ba1b
Compare
evict
force-pushed
the
vr/security/prevent-command-injection
branch
from
681ba1b to
2eb0830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should verify the result from the server, and make sure it's a URL. Additionally, the
startpattern was dangerous and allows command injection, so we useOpenURLfromurl.dlldirectly.