Skip to content

Conversation

@chrapkowski-sg
Copy link
Contributor

No description provided.

@chrapkowski-sg chrapkowski-sg force-pushed the updated-net-sdk-to-version-10 branch 3 times, most recently from 273c89b to 86c9449 Compare December 17, 2025 13:52
@jupblb jupblb self-requested a review December 17, 2025 14:10
@jupblb
Copy link
Member

jupblb commented Dec 17, 2025

This needs to be updated in a few additional places, like GitHub Actions. For reference see 8->9 migration PR: #75.

@chrapkowski-sg chrapkowski-sg force-pushed the updated-net-sdk-to-version-10 branch 2 times, most recently from 046d2df to 815c091 Compare December 17, 2025 14:18
Copy link
Member

@jupblb jupblb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the old PR we probably also need snapshot ouput at snapshots/output-net10.0

<PackageReference Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
</ItemGroup>

<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why is there a diff here? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending, change to match Windows and minimize diff

@chrapkowski-sg chrapkowski-sg force-pushed the updated-net-sdk-to-version-10 branch 2 times, most recently from 2bb9cf6 to ccaaa85 Compare December 17, 2025 14:27
@chrapkowski-sg chrapkowski-sg force-pushed the updated-net-sdk-to-version-10 branch from ccaaa85 to 93da7b2 Compare December 17, 2025 14:30
@chrapkowski-sg chrapkowski-sg merged commit 6c2e79b into sourcegraph:main Dec 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants