Skip to content

Fix: Allow empty result string in reviewDiff validation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Felipe-RA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Allow empty result string in reviewDiff validation #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/review/reviewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ export const reviewDiff = async (
}
console.log('[Amp] Iterator completed');

// Check if threadId and result are defined
if (!threadId || !result) throw new Error('Amp review failed');
// Check if threadId is defined (result can be empty when AI only uses tools)
if (!threadId) throw new Error('No thread ID received from Amp');

return { success: true, threadId, result, commentsFilePath };
} catch (error) {
Expand Down