Skip to content

fix(web): Confluence creds stale cache + configured badges on settings disclosures #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstuart0 merged 1 commit into from
May 6, 2026
Merged

fix(web): Confluence creds stale cache + configured badges on settings disclosures #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion web/src/app/(app)/repositories/[id]/wiki-settings-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,9 +2207,14 @@ export function WikiSettingsPanel({
const progressRef = useRef<HTMLDivElement>(null);
const summaryRef = useRef<HTMLDivElement>(null);

// Fetch global settings (for kill-switch + credential availability)
// Fetch global settings (for kill-switch + credential availability).
// network-only prevents the Urql document cache from serving a stale
// confluenceToken/notionToken: null when the user saved creds on the
// /settings/living-wiki page (which bypasses Urql entirely via authFetch)
// and then navigated here before the cache entry expired.
const [{ data: globalData, fetching: globalFetching }] = useQuery({
query: LIVING_WIKI_GLOBAL_SETTINGS_QUERY,
requestPolicy: "network-only",
});
const global: GlobalSettings = globalData?.livingWikiSettings ?? {};

Expand Down
33 changes: 27 additions & 6 deletions web/src/app/(app)/settings/living-wiki/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,16 @@ function Toggle({
);
}

function Disclosure({ label, children }: { label: string; children: React.ReactNode }) {
function Disclosure({
label,
children,
configured,
}: {
label: string;
children: React.ReactNode;
/** When provided, renders a status badge beside the label. */
configured?: boolean;
}) {
const [open, setOpen] = useState(false);
return (
<div className="border-t border-[var(--border-subtle)] pt-4">
Expand All @@ -295,7 +304,19 @@ function Disclosure({ label, children }: { label: string; children: React.ReactN
onClick={() => setOpen((o) => !o)}
className="flex w-full items-center justify-between text-sm font-medium text-[var(--text-primary)] hover:text-[var(--accent-primary)]"
>
<span>{label}</span>
<span className="flex items-center gap-2">
{label}
{configured === true && (
<span className="inline-flex items-center rounded-full border border-[var(--color-success,#22c55e)] bg-[rgba(34,197,94,0.1)] px-2 py-0.5 text-xs font-medium text-[#16a34a]">
Configured
</span>
)}
{configured === false && (
<span className="inline-flex items-center rounded-full border border-[var(--border-default)] bg-[var(--bg-subtle)] px-2 py-0.5 text-xs font-medium text-[var(--text-tertiary)]">
Not configured
</span>
)}
</span>
<span className="text-xs text-[var(--text-secondary)]">{open ? "collapse" : "expand"}</span>
</button>
{open && <div className="mt-4 space-y-6">{children}</div>}
Expand Down Expand Up @@ -517,7 +538,7 @@ export default function LivingWikiSettingsPage() {

{/* ── GitHub integration ── */}
<Panel className="space-y-6">
<Disclosure label="GitHub integration">
<Disclosure label="GitHub integration" configured={!!githubToken}>
<FieldLabel
label="Personal Access Token (or App token)"
help="A GitHub PAT or GitHub App installation token. Needs repo:read and pull_request:write scope to open wiki-diff PRs. Works with both PATs and GitHub App tokens — SourceBridge treats them identically."
Expand All @@ -529,7 +550,7 @@ export default function LivingWikiSettingsPage() {

{/* ── GitLab integration ── */}
<Panel className="space-y-6">
<Disclosure label="GitLab integration">
<Disclosure label="GitLab integration" configured={!!gitlabToken}>
<FieldLabel
label="PRIVATE-TOKEN"
help="A GitLab personal or project access token. Needs read_repository and write_repository scope to commit wiki changes as merge requests."
Expand All @@ -541,7 +562,7 @@ export default function LivingWikiSettingsPage() {

{/* ── Confluence integration ── */}
<Panel className="space-y-6">
<Disclosure label="Confluence integration">
<Disclosure label="Confluence integration" configured={!!confluenceToken}>
<div className="space-y-4">
<div>
<FieldLabel
Expand Down Expand Up @@ -594,7 +615,7 @@ export default function LivingWikiSettingsPage() {

{/* ── Notion integration ── */}
<Panel className="space-y-6">
<Disclosure label="Notion integration">
<Disclosure label="Notion integration" configured={!!notionToken}>
<FieldLabel
label="Integration token"
help="Create an internal integration at notion.so/profile/integrations and share the target databases with it. The token starts with 'secret_'. SourceBridge uses this to read and write Notion page blocks."
Expand Down
Loading