This repository was archived by the owner on Aug 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add Orientation #83
Open
Adimote
wants to merge
11
commits into
master
Choose a base branch
from
add_new_vision_features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−3
Open
Add Orientation #83
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
46076a3
add orientation data type to markers
Adimote 728f929
add Orientation to markers
Adimote 0e6e164
add Orientation to tests
Adimote 6673079
update versions being tested against
Adimote 831d611
Merge branch 'master' into add_new_vision_features
Adimote 3906827
bump sb-vision to be the latest orientation branch
Adimote ca54c3e
use humans as an analogy for rotations
Adimote 4e59cbb
"a marker" -> "the marker"
Adimote 6018425
say in what order the rotations are applied
Adimote 5a3e27d
fix linting error
Adimote 7535af1
clarify what the transforms are made relative to
Adimote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the order of application of the angles, and/or do they always apply to the cartesian axes of the camera?
A camera-relative interpretation of
(45°, 90°, 0)is as follows: consider a marker which is leaning forwards by 45° but placed on a horizontal rotating platform (like a "lazy susan"); then rotate the platform by 90°.A marker-relative interpretation is as follows: consider a marker perpendicular to a rotating platform which is angled 45° towards the observer (like a lazy susan on the surface of a table which has been half-pushed over); then rotate the platform by 90°.
In both scenarios the marker is now facing off to the side, however in the former its baseline is still horizontal while in the latter its baseline is at a 45° to the horizontal.
I'm not sure which of the two systems is easier to think about, nor which we've got data for. We should find out and document this however.
Note that if we apply the angles in the reverse order (
zthenythenx) then the two scenarios above change roles.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adimote I see this is partially resolved by 6018425, thanks for that, though we still don't describe whether the rotations are relative to the marker or the camera.
I think I hope that they're relative to the fixed frame of the camera (I'm expecting that that would make the angles for a pair of markers more easily comparable), though I've not explore enough examples to know which is better/easier to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took me a while to figure this out, but I'm pretty sure the rotations are actually applied relative to the marker. I've added this detail in 7535af1 This means an upside-down marker would report inverse
rot_y. We might want to investigate how to make this easier for the students to use in a later update.