Add better error messages for duplicate symbols #581
+194
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d variable, and vice versa
MathSAT passed these tests by accident as it does not allow Ufs with boolean arguments and will throw an IllegalArgumentException. The tests expects this exception, but for a completely different reason
kfriedberger
approved these changes
Jan 14, 2026
Member
kfriedberger
left a comment
kfriedberger
left a comment
There was a problem hiding this comment.
Looks good to me, overall,
I have not tested it on larger scale, so maybe one could execute some CPAchecker benchmarks with the new implementation sooner or later.
src/org/sosy_lab/java_smt/solvers/princess/PrincessFunctionDeclaration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
this PR fixes issues with name collisions on CVC4/5 and Princess. None of these solvers support variable/Uf names to be overloaded, however, checks for name collisions were missing or broken. Because of this, duplicate symbols could be declared, but the solver would still crash when trying to use these new symbols. This PR fixes the checks and makes sure that a more user-friendly error message is printed when trying to redefine an existing symbol