Skip to content

Fix memory leak in get_html_source (thanks @mreitinger for patch) #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscarty merged 1 commit into from
Oct 16, 2020
Merged

Fix memory leak in get_html_source (thanks @mreitinger for patch) #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/WWW/WebKit2/Inspector.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,20 @@ sub get_body_text {
sub get_html_source {
my ($self) = @_;

my $html_source;
my $resource = $self->view->get_main_resource();
my $done = 0;

return '' unless $resource;

$resource->get_data(undef, sub {
my ($resource, $result, $user_data) = @_;
my $result;

$html_source = $resource->get_data_finish($result);
$done = 1;
$resource->get_data(undef, sub {
$result = $_[1]; #store GAsyncResult, used for the _finish call later
}, undef);

Gtk3::main_iteration while Gtk3::events_pending or not $done;
#wait for the callback to fire
Gtk3::main_iteration while Gtk3::events_pending or not defined $result;

my $html_source = $resource->get_data_finish($result);

# get_data_finish returns a byte-array, turn it into a human readable string
my $html_string = decode_utf8(join('', map chr, @$html_source));
Expand Down