Skip to content

Conversation

@pvoglhofer
Copy link
Contributor

We already discovered issues with about:blank requests, as these are not
regular navigation requests. These peculiarities extend to other about:
requests as well, so they should be disregarded in the decide-policy
handling too.

I'm not entirely sure this will help #80 , but it is a potential source for hanging during the 'open' call (running iframe_open.t without the changes to WebKit2.pm produces a hang)

We already discovered issues with about:blank requests, as these are not
regular navigation requests. These peculiarities extend to other about:
requests as well, so they should be disregarded in the decide-policy
handling too.
@pvoglhofer pvoglhofer force-pushed the about_navigation_policy branch from 5d1810e to 563d2c2 Compare October 9, 2020 08:16
@pvoglhofer pvoglhofer requested a review from niner October 9, 2020 09:18
@niner
Copy link
Collaborator

niner commented Oct 9, 2020

What happens if there is an active navigation request already and we navigate to about:blank? We can't set the active navigation request to about:blank but should we at least remove the existing (and obsolete) one?

@jscarty
Copy link
Member

jscarty commented Oct 22, 2020

What happens if there is an active navigation request already and we navigate to about:blank? We can't set the active navigation request to about:blank but should we at least remove the existing (and obsolete) one?

Depends on how that happens. If it is set and WWW::Webkit2 activates something it will most likely get stuck inside process page load, nothing is loading so is_loading and Gtk3::events_pending will return false while active_navigation_action will always return true.

I can't think of a situation where it will be set and then navigation to an about:* page happens. I assume it should be unset when resouce-load-signal is activated.

Unset active_navigation_action if it is set and we are trying to
navigate to an about* page and if a failed-with-tls-errors happens
within the resource-load-started signal.
@jscarty jscarty force-pushed the about_navigation_policy branch from 3776db7 to e1c1760 Compare October 30, 2020 07:31
@jscarty jscarty added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working help wanted Extra attention is needed question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants