Open
Conversation
Current Search/Incsearach highlight sets the full background color to yellow (common in the majority of colorscheme), but results in a distracting highlight. This PR proposes a less distracting hightlight, using yellow for the foreground color instead. Moreover style bold and underline help distinguing the text in case of styled filetype (e.g. markdown or programming languages).
Added the following highlights classes * header, which is the same as the standard "Title" highlight target * Quote * Code * Link
incsearch and search have the same hightlight, making it more hard to distinguish the current selected string among the one matching the search. Use underline to hightlight the current selected element
When two or more buffers are open at the same time, the one without the focus has a blue background which, being more visible, can make the user think that this is the on-focus buffer, while it is not. Attempt fix setting Pmenu colors to have the same bg color of the on focus split buffer, while using a grayed fg color.
|
@abcinje could you take a look at this PR please? The current highlighting isn't that great, though the rest of the colours are superb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Search/Incsearach highlight sets the full background color to
yellow (common in the majority of colorscheme), but results in a
distracting highlight.
This PR proposes a less distracting highlight, using yellow as the
foreground color instead. Moreover, style bold and underline help
see the text in case of styled filetype (e.g. markdown or
programming languages).
Current
Proposed
