Skip to content

[action] [PR:184] [restapi] Fix nil pointer dereference in monitor_certs when cert file is missing #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mssonicbld merged 1 commit into from
Apr 30, 2026
Merged

[action] [PR:184] [restapi] Fix nil pointer dereference in monitor_certs when cert file is missing #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions go-server-server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,23 +102,37 @@ func signal_handler(messenger chan<- int, wgroup *sync.WaitGroup) {

func monitor_certs(messenger chan<- int, wgroup *sync.WaitGroup) {
defer wgroup.Done()
client_cert_finfo, _ := os.Lstat(*sw.ClientCertFlag)
client_cert_finfo, err := os.Lstat(*sw.ClientCertFlag)
if err != nil {
log.Fatalf("error: couldn't stat client cert file: %s", err)
}
prev_client_cert_mtime := client_cert_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", client_cert_finfo.Name(), prev_client_cert_mtime.Unix())

server_cert_finfo, _ := os.Lstat(*sw.ServerCertFlag)
server_cert_finfo, err := os.Lstat(*sw.ServerCertFlag)
if err != nil {
log.Fatalf("error: couldn't stat server cert file: %s", err)
}
prev_server_cert_mtime := server_cert_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", server_cert_finfo.Name(), prev_server_cert_mtime.Unix())

sever_key_finfo, _ := os.Lstat(*sw.ServerKeyFlag)
sever_key_finfo, err := os.Lstat(*sw.ServerKeyFlag)
if err != nil {
log.Fatalf("error: couldn't stat server key file: %s", err)
}
prev_sever_key_mtime := sever_key_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", sever_key_finfo.Name(), prev_sever_key_mtime.Unix())

time.Sleep(CERT_MONITOR_FREQUENCY)

for {
reload := false
client_cert_finfo, _ := os.Lstat(*sw.ClientCertFlag)
client_cert_finfo, err := os.Lstat(*sw.ClientCertFlag)
if err != nil {
log.Printf("error: couldn't stat client cert file: %s", err)
time.Sleep(CERT_MONITOR_FREQUENCY)
continue
}
client_cert_mtime := client_cert_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", client_cert_finfo.Name(), client_cert_mtime.Unix())
if client_cert_mtime != prev_client_cert_mtime {
Expand All @@ -127,7 +141,12 @@ func monitor_certs(messenger chan<- int, wgroup *sync.WaitGroup) {
}
prev_client_cert_mtime = client_cert_mtime

server_cert_finfo, _ := os.Lstat(*sw.ServerCertFlag)
server_cert_finfo, err := os.Lstat(*sw.ServerCertFlag)
if err != nil {
log.Printf("error: couldn't stat server cert file: %s", err)
time.Sleep(CERT_MONITOR_FREQUENCY)
continue
}
server_cert_mtime := server_cert_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", server_cert_finfo.Name(), server_cert_mtime.Unix())
if server_cert_mtime != prev_server_cert_mtime {
Expand All @@ -136,7 +155,12 @@ func monitor_certs(messenger chan<- int, wgroup *sync.WaitGroup) {
}
prev_server_cert_mtime = server_cert_mtime

sever_key_finfo, _ := os.Lstat(*sw.ServerKeyFlag)
sever_key_finfo, err := os.Lstat(*sw.ServerKeyFlag)
if err != nil {
log.Printf("error: couldn't stat server key file: %s", err)
time.Sleep(CERT_MONITOR_FREQUENCY)
continue
}
sever_key_mtime := sever_key_finfo.ModTime()
log.Printf("trace: Last modified time of %s is %d", sever_key_finfo.Name(), sever_key_mtime.Unix())
if sever_key_mtime != prev_sever_key_mtime {
Expand Down
Loading