[sonic-redfish] Sonic Redfish support with OpenBMC D-Bus#1
Conversation
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
4e94c81 to
0dce995
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
0dce995 to
842c43f
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
76f6aea to
c9517fe
Compare
|
/azp run |
1 similar comment
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
1 similar comment
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
5261c49 to
cd66795
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
b308a60 to
ebf76be
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
LGTM.. Can you add details in description as to which files/components are added newly and which are part of original openbmc/bmcweb - Will concentrate on that part to review, it is quite a big code to review :-) Additional question do we have the code to handle the Oem URIs here .. ? especially templatizing the alert/tememetry data that can come in any formats or that is coming as subsequent PR |
thank you @judyjoseph for looking into this. bmcweb - Upstream code (mostly untouched )
Build
sonic-dbus-bridge - Bridge SONiC Redis to D-Bus for bmcweb integration
Oem URIs here:
|
|
@chinmoy-nexthop if we do a squash commit all the changes will be merged into a single commit Is that ok ? Or do you want to segregate your 24 commits into something same 5 meaningful commits based on functionality -- in that case we will just commit as such instead of doing a squash single commit. |
…omponent - Add Makefile.build as central build orchestration with Docker-only builds - Add Docker build environment (debian:trixie) with all required dependencies - Add patch management system with series file for bmcweb integration - Add submodule setup scripts for bmcweb and sdbusplus dependencies - Add Docker container configuration for runtime deployment - Update README.md with build instructions and system architecture sonic-dbus-bridge component: - Implements D-Bus to Redis state synchronization for SONiC integration - Provides D-Bus interfaces for Redfish API consumption by bmcweb - Supports inventory management via FRU and platform JSON adapters - Implements user management with PAM integration - Implements software update management for BMC firmware - Uses Redis pub/sub for state change notifications - Built with C++23, Meson build system, and sdbusplus library Build system features: - Docker-only compilation for build consistency across environments - Meson-based builds for both bmcweb and sonic-dbus-bridge - C++23 support with proper dependency resolution via wrap files - Parallel build support via SONIC_CONFIG_MAKE_JOBS variable - Clean separation of build artifacts and source code Signed-off-by: Chinmoy Dey <chinmoy@nexthop.ai> Co-authored-by: Shreyansh Jain <shreyansh@nexthop.ai>
c9d9933 to
1d09fa9
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
Done @judyjoseph . thanks |
judyjoseph
left a comment
There was a problem hiding this comment.
LGTM to start as base
There was a problem hiding this comment.
Review notes (non-blocking, OK to proceed as initial drop):
- Config file is ignored: ConfigManager::load() does not parse YAML and always uses defaults, so config.yaml is unused. Consider implementing YAML parsing (yaml-cpp) or mark config as placeholder in README.
- config.yaml indentation is invalid: platform/dbus/update/logging/features/persistence blocks are indented under redis, and fru_eeprom_paths list items are mis-indented. A YAML parser will fail or parse incorrectly. Please fix structure.
- D-Bus policy too permissive for sensitive services: User.Manager and State.Host allow all users to send methods. Consider restricting to root/bmcweb or tighter policy group.
Happy to proceed with merge now and track these as follow-ups.
Thank you @yxieca for review . I will take care your feedback in a follow up PR with proper Config manager enhancements for sonic-redfish. |
Guideline for Reviewer :
About the Changes
OpenBMC Standard Compliance:
Mimicking OpenBMC:
Data Model Mismatch:
Keep bmcweb Pristine:
Hardware Data Aggregation:
Bidirectional Communication:
Graceful Degradation:
sonic-dbus-bridge component:
Build system features: