Skip to content

[debian/rules]: atomic symlink replacement for /lib/modules/<KVER>/{build,source} #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhouse-nexthop wants to merge 1 commit into
base: sdk-6.5.35-dnx
Choose a base branch
from
Open

[debian/rules]: atomic symlink replacement for /lib/modules/<KVER>/{build,source} #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions debian/rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,24 @@ build-arch: configure-stamp build-arch-stamp
build-arch-stamp:
dh_testdir

# create links
# Create the /lib/modules/$(KVER_ARCH)/{build,source} symlinks
# atomically. Using `rm` followed by `ln -s` leaves a window of
# tens to hundreds of milliseconds where the symlink does not
# exist on disk. Other concurrent platform-modules-* recipes
# (e.g. sonic-platform-modules-dell's debian/rules) iterate over
# their MODULE_DIRS running `make -C /lib/modules/$(KVER_ARCH)/build
# M=... clean` per platform, and a single iteration that lands in
# that window fails with "No such file or directory" on the
# kernel build dir, aborting the whole recipe.
#
# `ln -sfn` performs the unlink + symlink in a single rename(2)
# syscall (via a hidden temp path), so the target name is never
# absent from a concurrent observer's point of view. The non-DNX
# variant of this Makefile (`platform/broadcom/saibcm-modules/`)
# already uses this form.
cd /; sudo mkdir -p /lib/modules/$(KVER_ARCH)
cd /; sudo rm /lib/modules/$(KVER_ARCH)/build
cd /; sudo rm /lib/modules/$(KVER_ARCH)/source
cd /; sudo ln -s /usr/src/linux-headers-$(KVER_COMMON)/ /lib/modules/$(KVER_ARCH)/source
cd /; sudo ln -s /usr/src/linux-headers-$(KVER_ARCH)/ /lib/modules/$(KVER_ARCH)/build
cd /; sudo ln -sfn /usr/src/linux-headers-$(KVER_COMMON)/ /lib/modules/$(KVER_ARCH)/source
cd /; sudo ln -sfn /usr/src/linux-headers-$(KVER_ARCH)/ /lib/modules/$(KVER_ARCH)/build
if [ ! -e /usr/src/linux-headers-$(KVER_COMMON)/include/generated ]; then \
sudo ln -s /usr/src/linux-headers-$(KVER_ARCH)/include/generated/ /usr/src/linux-headers-$(KVER_COMMON)/include/generated; \
fi
Expand Down