Conversation
|
This only fixes the issues that could be automatically fixed. There's still a handful of things that couldn't be automatically addressed. |
mamhoff
left a comment
There was a problem hiding this comment.
I like this change, and I think it sets us up on a good track. Why not mark it as ready for review?
|
I just bugged @AlistairNorman to get this wrapped when he has time. Would love to see this put to bed once and for all. |
Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
|
I'll definitely work on it but there are 94 offences that can't be automatically corrected |
deaa49d to
5196741
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
==========================================
- Coverage 89.51% 89.09% -0.43%
==========================================
Files 981 785 -196
Lines 20504 17318 -3186
==========================================
- Hits 18355 15429 -2926
+ Misses 2149 1889 -260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just put them into the ignore/to-do file for now. They can be corrected later! |
Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
These changes have been reviewed individually to ensure these are safe. Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
4bebb8c to
412bb5f
Compare
Standard wants the shared logic out of both branches, but the condition mutates the order, so the sequence matters. Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
These do need to be or equals so that we don't overwrite these if people have changed them. Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
This isn't from Standard. Alistair just likes it better. (So does everyone else.) Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd>
Summary
This builds off of #6241
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: