Skip to content

Conversation

@AlistairNorman
Copy link
Contributor

Summary

A little fix along with adding Ruby 4 to CI. Fixes an issue that was surfaced when @tvdeyen ran CI with Ruby 4 in PR #6403

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

tvdeyen and others added 2 commits January 5, 2026 14:36
Until released needs solidus_auth_devise main branch for now
i18n-tasks gets reverted to an earlier version when upgrading to Ruby 4.
For some reason 0.9.0 allows Ruby 4 but 0.9.37 doesn't and reverting
back to 0.9.0 introduces bugs that were fixed in subsequent versions.
These versions are all quite old and we can now update to 1.1.
@AlistairNorman AlistairNorman requested a review from a team as a code owner January 24, 2026 01:01
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 24, 2026
@AlistairNorman AlistairNorman mentioned this pull request Jan 24, 2026
5 tasks
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (f8779d6) to head (141e965).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6410      +/-   ##
==========================================
+ Coverage   89.48%   89.50%   +0.01%     
==========================================
  Files         980      981       +1     
  Lines       20438    20479      +41     
==========================================
+ Hits        18289    18329      +40     
- Misses       2149     2150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants