fix class/prototype getters not being reactive#2343
Merged
Conversation
🦋 Changeset detectedLatest commit: 72e97e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timbasel
changed the title
Contributor
Author
|
@ryansolid It's been a while, but is there anything that can be done to get this fix implemented so I don't have to run a custom version of solid for some my projects? |
Member
|
Sorry it has taken me a while to get back to Solid 1.0 stuff especially wanted to make sure I would be fine with these changes in 2.0 (didn't have this concern for createMutable). |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes class getter methods not being reactive.
It is the same fix that was already applied for
createMutablein #2027.