Skip to content

Fix Mistake Popup visibility on dark mode #82 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illia-romanenko merged 3 commits into from
Aug 14, 2025
Merged

Fix Mistake Popup visibility on dark mode #82 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34b7253
Fix Mistake Popup visibility on dark mode #82
Jun 13, 2025
d25f69e
Merge branch 'main' into popup-visibility
illia-romanenko Aug 11, 2025
b71ddfe
Merge branch 'main' into popup-visibility
illia-romanenko Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ migrate_working_dir/
.dart_tool/
.packages
build/
/.flutter-plugins-dependencies
/example/.flutter-plugins-dependencies
16 changes: 12 additions & 4 deletions lib/src/utils/mistake_popup.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ class LanguageToolMistakePopup extends StatelessWidget {

final availableSpace = _calculateAvailableSpace(context);

final colorScheme = Theme.of(context).colorScheme;

return PointerInterceptor(
child: ConstrainedBox(
constraints: BoxConstraints(
Expand All @@ -125,9 +127,14 @@ class LanguageToolMistakePopup extends StatelessWidget {
vertical: verticalMargin,
),
decoration: BoxDecoration(
color: const Color.fromRGBO(241, 243, 248, 1.0),
color: colorScheme.surface.withValues(alpha: 0.9),
borderRadius: BorderRadius.circular(_borderRadius),
boxShadow: const [BoxShadow(color: Colors.grey, blurRadius: 8)],
boxShadow: [
BoxShadow(
color: colorScheme.onSurface.withValues(alpha: 0.5),
blurRadius: 8,
),
],
),
padding: const EdgeInsets.only(
top: 8,
Expand Down Expand Up @@ -180,7 +187,7 @@ class LanguageToolMistakePopup extends StatelessWidget {
margin: const EdgeInsets.only(top: 8),
padding: const EdgeInsets.all(padding),
decoration: BoxDecoration(
color: Colors.white,
color: colorScheme.surface,
borderRadius: BorderRadius.circular(_borderRadius),
),
child: SingleChildScrollView(
Expand All @@ -194,7 +201,8 @@ class LanguageToolMistakePopup extends StatelessWidget {
child: Text(
mistake.type.name.capitalize(),
style: TextStyle(
color: Colors.grey.shade700,
color:
colorScheme.onSurface.withValues(alpha: 0.7),
fontSize: _mistakeNameFontSize,
fontWeight: FontWeight.w600,
letterSpacing: _titleLetterSpacing,
Expand Down