Example tests for Solid Notifications and WebSocketSubscription2021 specifications#86
Draft
Example tests for Solid Notifications and WebSocketSubscription2021 specifications#86
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
Author
|
See solid/notifications#141 re implementations |
csarven
requested changes
Apr 4, 2023
Collaborator
csarven
left a comment
There was a problem hiding this comment.
I suggest closing this WebSocketSubscription2021 or at least updating significantly towards WebSocketSubscription2023.
Also update to work towards https://solid.github.io/notifications/protocol , which has a few things towards 0.3 that may be better off to focus on than the released 0.2 ( https://solidproject.org/TR/2022/notifications-protocol-20221231 ). But generally okay to approach 0.2 - just refer to specific URIs as usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








This is some provisional work on testing these notifications related specs. Of note:
@notificationstag.protocoldon't specify a subscription type as they are meant to test the protocol, not a particular subscription type. Since the discovery mechanism is not yet specifiedsubscription-endpoint.featureuses an alternative implementation and defaults toWebSocketSubscription2021. It also contains code which should allow it to pick the first available subscription type after notification channel discovery but this is untested as there are no implementations available.solid-0.1protocol since that is insecure and will not be retained in the Solid specification.Comments on this would be very welcome.