feat(web): 비로그인 홈 학교 검색 UI 추가#519
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
🔍 Walkthrough이 PR은 홈 페이지 UI를 재구성하고 컴포넌트 아키텍처를 개선하는 작업입니다:
📊 Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 👥 Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/app/`(home)/_ui/HomeUniversitySearchSection/index.tsx:
- Around line 22-27: languageOptions is building dropdown items by using
Object.keys(LANGUAGE_TEST_TYPE_MAP) and assigning the raw key to label, which
may expose internal codes; change the mapping to iterate
Object.entries(LANGUAGE_TEST_TYPE_MAP) inside the useMemo and set label to the
user-facing name from the entry (e.g., the map's value/display property) while
keeping value as the code so the dropdown shows friendly labels but preserves
the original value; update the code that consumes languageOptions if it expects
the old shape.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9fce3231-c8c6-48a8-ae78-84e16d64ea20
📒 Files selected for processing (11)
apps/web/src/app/(home)/_ui/HomeActionLinks/index.tsxapps/web/src/app/(home)/_ui/HomeUniversitySearchSection/index.tsxapps/web/src/app/(home)/_ui/UniversityList/_hooks/useHomeUniversityList.tsapps/web/src/app/(home)/_ui/UniversityList/_hooks/useRegionHandler.tsapps/web/src/app/(home)/_ui/UniversityList/index.tsxapps/web/src/app/(home)/page.tsxapps/web/src/app/university/[homeUniversity]/search/_ui/SearchPageContent.tsxapps/web/src/app/university/score/submit/gpa/GpaSubmitForm.tsxapps/web/src/app/university/score/submit/language-test/LanguageTestSubmitForm.tsxapps/web/src/app/university/search/PageContent.tsxapps/web/src/components/search/CustomDropdown.tsx
💤 Files with no reviewable changes (1)
- apps/web/src/app/(home)/_ui/UniversityList/_hooks/useRegionHandler.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e658784d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Object.keys(LANGUAGE_TEST_TYPE_MAP).map((value) => ({ | ||
| value, | ||
| label: value, | ||
| })), |
There was a problem hiding this comment.
The new home search dropdown builds its options with Object.keys(LANGUAGE_TEST_TYPE_MAP) and sets label to the enum key, so users see internal values like TOEFL_IBT instead of the localized display text already defined in LANGUAGE_TEST_TYPE_MAP. This makes the filter harder to understand and is inconsistent with the existing search forms that map to display labels; build options from Object.entries so the label uses the mapped text.
Useful? React with 👍 / 👎.
yoonc01
force-pushed
the
home-university-search-entry
branch
from
7e65878 to
a32d719
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a32d7196af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const PREVIEW_UNIVERSITY_COUNT = 3; | ||
|
|
||
| const useHomeUniversityList = (allRegionsUniversityList: AllRegionsUniversityList) => { | ||
| const [selectedHomeUniversity, setSelectedHomeUniversity] = useState<string | null>(ALL_HOME_UNIVERSITY_CHOICE); |
There was a problem hiding this comment.
ButtonTab toggles the current choice to null when a selected chip is clicked again, but this new hook no longer restores a default value (the removed useRegionHandler used to force fallback to "전체"). In practice this leaves the home list with no active chip and makes moreHref fall back to /university, so users can accidentally lose the school-specific context by re-clicking the active chip.
Useful? React with 👍 / 👎.
yoonc01
force-pushed
the
home-university-search-entry
branch
from
a32d719 to
adeb891
Compare
yoonc01
force-pushed
the
home-university-search-entry
branch
from
adeb891 to
0728446
Compare
yoonc01
force-pushed
the
home-university-search-entry
branch
from
0728446 to
05b595f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05b595fe65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!shouldAttemptRefresh) { | ||
| setInitialized(true); | ||
| return; |
There was a problem hiding this comment.
This early return prevents postReissueToken() from running whenever shouldAttemptRefresh is false, but shouldAttemptRefresh is reset to false by clearAccessToken() after any reissue failure (including transient network/API errors). In that scenario, users who still have a valid HttpOnly refresh cookie will be treated as permanently logged out on subsequent app loads because initialization now skips reissue entirely.
Useful? React with 👍 / 👎.
1 participant
작업 내용
파견 학교 찾기검색 영역을 노출하도록 변경했습니다.HomeActionLinks로 분리했습니다.전체 학교 리스트chip을 권역 기준에서전체/학교별기준으로 변경했습니다.더보기는 선택된 학교 목록 페이지로 이동하도록 변경했습니다.CustomDropdown을 공용 컴포넌트 위치로 이동했습니다.특이 사항
/페이지를 동적 렌더링(force-dynamic)으로 변경했습니다.리뷰 요구사항 (선택)
전체 학교 리스트의 학교별 chip 선택 시더보기를 학교별 목록으로 보내는 동작이 적절한지 확인 부탁드립니다.