Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bd909d5
feat: HTTP 요청/응답 로깅 필터 구현
sukangpunch Dec 31, 2025
ff145a8
feat: ExceptionHandler에 중복 로깅 방지 플래그 및 userId 로깅 추가
sukangpunch Dec 31, 2025
88dee74
feat: API 수행시간 로깅 인터셉터 추가
sukangpunch Dec 31, 2025
69ccdd6
feat: ApiPerf 인터셉터, Logging 필터 빈 등록
sukangpunch Jan 1, 2026
222980c
refactor: logback 설정 변경
sukangpunch Jan 1, 2026
d49b83b
feat: 쿼리 별 수행시간 메트릭 모니터링 추가
sukangpunch Jan 1, 2026
d6793d3
refactor: 비효율적인 Time 빌더 생성 개선
sukangpunch Jan 1, 2026
db2c7f3
feat: 로깅을 위해 HttpServeletRequest 속성에 userId 추가
sukangpunch Jan 1, 2026
5a11264
refactor: logback 설정 중 local은 console만 찍도록 수정
sukangpunch Jan 1, 2026
1e4cfe2
refactor: FILE_PATTERN -> LOG_PATTERN 으로 수정
sukangpunch Jan 1, 2026
ac27d4f
test: TokenAuthenticationFilter에서 request에 userId 설정 검증 추가
sukangpunch Jan 2, 2026
109a4e4
refacotr: 코드 래빗 리뷰사항 반영
sukangpunch Jan 2, 2026
436256a
refactor: 리뷰 내용 반영
sukangpunch Jan 3, 2026
f12d81e
refactor: 로깅 시 민감한 쿼리 파라미터 마스킹
sukangpunch Jan 6, 2026
69022fa
refactor: CustomExceptionHandler 원상복구
sukangpunch Jan 6, 2026
4d1ffdc
refactor: 리뷰 사항 반영
sukangpunch Jan 6, 2026
0f461b8
fix: decode를 두 번 하는 문제 수정
sukangpunch Jan 8, 2026
d346239
test: 로깅 관련 filter, interceptor 테스트 추가
sukangpunch Jan 8, 2026
dc04ef6
refactor: 코드래빗 리뷰사항 반영
sukangpunch Jan 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ dependencies {
implementation 'org.hibernate.validator:hibernate-validator'
implementation 'com.amazonaws:aws-java-sdk-s3:1.12.782'
implementation 'org.springframework.boot:spring-boot-starter-websocket'

// Database Proxy
implementation 'net.ttddyy.observation:datasource-micrometer:1.2.0'
}

tasks.named('test', Test) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package com.example.solidconnection.common.config.datasource;

import com.example.solidconnection.common.listener.QueryMetricsListener;
import javax.sql.DataSource;
import lombok.RequiredArgsConstructor;
import net.ttddyy.dsproxy.support.ProxyDataSourceBuilder;
import org.springframework.boot.autoconfigure.jdbc.DataSourceProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Primary;

@RequiredArgsConstructor
@Configuration
public class DataSourceProxyConfig {

private final QueryMetricsListener queryMetricsListener;

@Bean
@Primary
public DataSource proxyDataSource(DataSourceProperties props) {
DataSource dataSource = props.initializeDataSourceBuilder().build();

return ProxyDataSourceBuilder
.create(dataSource)
.listener(queryMetricsListener)
.name("main")
.build();
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
package com.example.solidconnection.common.config.web;

import com.example.solidconnection.common.filter.HttpLoggingFilter;
import com.example.solidconnection.common.interceptor.ApiPerformanceInterceptor;
import com.example.solidconnection.common.interceptor.RequestContextInterceptor;
import com.example.solidconnection.common.resolver.AuthorizedUserResolver;
import com.example.solidconnection.common.resolver.CustomPageableHandlerMethodArgumentResolver;
import java.util.List;
import lombok.RequiredArgsConstructor;
import org.springframework.boot.web.servlet.FilterRegistrationBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.Ordered;
import org.springframework.web.method.support.HandlerMethodArgumentResolver;
import org.springframework.web.servlet.config.annotation.InterceptorRegistry;
import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;

@Configuration
Expand All @@ -14,6 +21,9 @@ public class WebMvcConfig implements WebMvcConfigurer {

private final AuthorizedUserResolver authorizedUserResolver;
private final CustomPageableHandlerMethodArgumentResolver customPageableHandlerMethodArgumentResolver;
private final HttpLoggingFilter httpLoggingFilter;
private final ApiPerformanceInterceptor apiPerformanceInterceptor;
private final RequestContextInterceptor requestContextInterceptor;

@Override
public void addArgumentResolvers(List<HandlerMethodArgumentResolver> resolvers) {
Expand All @@ -22,4 +32,23 @@ public void addArgumentResolvers(List<HandlerMethodArgumentResolver> resolvers)
customPageableHandlerMethodArgumentResolver
));
}

@Override
public void addInterceptors(InterceptorRegistry registry){
registry.addInterceptor(apiPerformanceInterceptor)
.addPathPatterns("/**")
.excludePathPatterns("/actuator/**");

registry.addInterceptor(requestContextInterceptor)
.addPathPatterns("/**")
.excludePathPatterns("/actuator/**");
}

@Bean
public FilterRegistrationBean<HttpLoggingFilter> customHttpLoggingFilter() {
FilterRegistrationBean<HttpLoggingFilter> filterBean = new FilterRegistrationBean<>();
filterBean.setFilter(httpLoggingFilter);
filterBean.setOrder(Ordered.HIGHEST_PRECEDENCE);
return filterBean;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
package com.example.solidconnection.common.filter;

import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
import java.net.URLDecoder;
import java.nio.charset.StandardCharsets;
import java.util.List;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.slf4j.MDC;
import org.springframework.http.HttpStatus;
import org.springframework.stereotype.Component;
import org.springframework.util.AntPathMatcher;
import org.springframework.web.filter.OncePerRequestFilter;

@Slf4j
@RequiredArgsConstructor
@Component
public class HttpLoggingFilter extends OncePerRequestFilter {

private static final AntPathMatcher PATH_MATCHER = new AntPathMatcher();
private static final List<String> EXCLUDE_PATTERNS = List.of("/actuator/**");
private static final List<String> EXCLUDE_QUERIES = List.of("token");
private static final String MASK_VALUE = "****";

@Override
protected void doFilterInternal(
HttpServletRequest request,
HttpServletResponse response,
FilterChain filterChain
) throws ServletException, IOException {

// 1) traceId 부여
String traceId = generateTraceId();
MDC.put("traceId", traceId);

boolean excluded = isExcluded(request);

// 2) 로깅 제외 대상이면 그냥 통과 (traceId는 유지: 추후 하위 레이어 로그에도 붙음)
if (excluded) {
try {
filterChain.doFilter(request, response);
} finally {
MDC.clear();
}
return;
}

printRequestUri(request);

try {
filterChain.doFilter(request, response);
printResponse(request, response);
} finally {
MDC.clear();
}
}

private boolean isExcluded(HttpServletRequest req) {
String path = req.getRequestURI();
for (String p : EXCLUDE_PATTERNS) {
if (PATH_MATCHER.match(p, path)) {
return true;
}
}
return false;
}

private String generateTraceId() {
return java.util.UUID.randomUUID().toString().replace("-", "").substring(0, 16);
}

private void printRequestUri(HttpServletRequest request) {
String methodType = request.getMethod();
String uri = buildDecodedRequestUri(request);
log.info("[REQUEST] {} {}", methodType, uri);
}

private void printResponse(
HttpServletRequest request,
HttpServletResponse response
) {
Long userId = (Long) request.getAttribute("userId");
String uri = buildDecodedRequestUri(request);
HttpStatus status = HttpStatus.valueOf(response.getStatus());

log.info("[RESPONSE] {} userId = {}, ({})", uri, userId, status);
}

private String buildDecodedRequestUri(HttpServletRequest request) {
String path = request.getRequestURI();
String query = request.getQueryString();

if(query == null || query.isBlank()){
return path;
}

String decodedQuery = decodeQuery(query);
String maskedQuery = maskSensitiveParams(decodedQuery);

return path + "?" + maskedQuery;
}

private String decodeQuery(String rawQuery) {
if(rawQuery == null || rawQuery.isBlank()){
return rawQuery;
}

try {
return URLDecoder.decode(rawQuery, StandardCharsets.UTF_8);
} catch (IllegalArgumentException e) {
log.warn("Query 디코딩 실패 parameter: {}, msg: {}", rawQuery, e.getMessage());
return rawQuery;
}
}

private String maskSensitiveParams(String decodedQuery) {
String[] params = decodedQuery.split("&");
StringBuilder maskedQuery = new StringBuilder();

for(int i = 0; i < params.length; i++){
String param = params[i];

if(!param.contains("=")){
maskedQuery.append(param);
}else{
int equalIndex = param.indexOf("=");
String key = param.substring(0, equalIndex);

if(isSensitiveParam(key)){
maskedQuery.append(key).append("=").append(MASK_VALUE);
}else{
maskedQuery.append(param);
}
}

if(i < params.length - 1){
maskedQuery.append("&");
}
}

return maskedQuery.toString();
}

private boolean isSensitiveParam(String paramKey) {
for (String sensitiveParam : EXCLUDE_QUERIES){
if(sensitiveParam.equalsIgnoreCase(paramKey)){
return true;
}
}
return false;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
package com.example.solidconnection.common.interceptor;

import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;
import org.springframework.web.servlet.HandlerInterceptor;

@Slf4j
@RequiredArgsConstructor
@Component
public class ApiPerformanceInterceptor implements HandlerInterceptor {
private static final String START_TIME_ATTRIBUTE = "startTime";
private static final String REQUEST_URI_ATTRIBUTE = "requestUri";
private static final int RESPONSE_TIME_THRESHOLD = 3_000;
private static final Logger API_PERF = LoggerFactory.getLogger("API_PERF");

@Override
public boolean preHandle(
HttpServletRequest request,
HttpServletResponse response,
Object handler
) throws Exception {

long startTime = System.currentTimeMillis();

request.setAttribute(START_TIME_ATTRIBUTE, startTime);
request.setAttribute(REQUEST_URI_ATTRIBUTE, request.getRequestURI());

return true;
}

@Override
public void afterCompletion(
HttpServletRequest request,
HttpServletResponse response,
Object handler,
Exception ex
) throws Exception {
Long startTime = (Long) request.getAttribute(START_TIME_ATTRIBUTE);
if(startTime == null) {
return;
}

long responseTime = System.currentTimeMillis() - startTime;

String uri = request.getRequestURI();
String method = request.getMethod();
int status = response.getStatus();

if (responseTime > RESPONSE_TIME_THRESHOLD) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으론 if-else 구조가 로직을 이해하는 데 더 좋을 거 같습니다 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다!

API_PERF.warn(
"type=API_Performance method_type={} uri={} response_time={} status={}",
method, uri, responseTime, status
);
}
else {
API_PERF.info(
"type=API_Performance method_type={} uri={} response_time={} status={}",
method, uri, responseTime, status
);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.example.solidconnection.common.interceptor;

import lombok.Getter;

@Getter
public class RequestContext {
private final String httpMethod;
private final String bestMatchPath;

public RequestContext(String httpMethod, String bestMatchPath) {
this.httpMethod = httpMethod;
this.bestMatchPath = bestMatchPath;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.example.solidconnection.common.interceptor;

public class RequestContextHolder {
private static final ThreadLocal<RequestContext> CONTEXT = new ThreadLocal<>();

public static void initContext(RequestContext requestContext) {
CONTEXT.remove();
CONTEXT.set(requestContext);
}

public static RequestContext getContext() {
return CONTEXT.get();
}

public static void clear(){
CONTEXT.remove();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package com.example.solidconnection.common.interceptor;

import static org.springframework.web.servlet.HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE;

import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import org.springframework.stereotype.Component;
import org.springframework.web.servlet.HandlerInterceptor;

@Component
public class RequestContextInterceptor implements HandlerInterceptor {

@Override
public boolean preHandle(
HttpServletRequest request,
HttpServletResponse response,
Object handler
) {
String httpMethod = request.getMethod();
String bestMatchPath = (String) request.getAttribute(BEST_MATCHING_PATTERN_ATTRIBUTE);

RequestContext context = new RequestContext(httpMethod, bestMatchPath);
RequestContextHolder.initContext(context);

return true;
}

@Override
public void afterCompletion(
HttpServletRequest request,
HttpServletResponse response,
Object handler, Exception ex
) {
RequestContextHolder.clear();
}
}
Loading
Loading