Skip to content

Add Register metrics #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madhurijustwatch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Register metrics #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae9aef
Add Register metrics
Feb 29, 2024
0b02bf3
Update the go mod
Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions entity_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,19 @@ func New(
if err != nil {
return nil, err
}
pr := prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: promMetricName,
Help: "A counter of hit/miss on the entity cache.",
},
[]string{"namespace", "hit"},
)
prometheus.MustRegister(pr)
return &EntityCache{
promHitCounter: prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: promMetricName,
Help: "A counter of hit/miss on the entity cache.",
},
[]string{"namespace", "hit"},
),

maxEntries: maxEntries,
ttr: ttr,
ttl: ttl,
promHitCounter: pr,
maxEntries: maxEntries,
ttr: ttr,
ttl: ttl,

cache: cache,
locker: locker.NewEntityLocker(),
Expand Down
4 changes: 3 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/solher/entitycache
module github.com/justwatch/entitycache

go 1.21.0

Expand All @@ -22,3 +22,5 @@ require (
golang.org/x/sys v0.8.0 // indirect
google.golang.org/protobuf v1.30.0 // indirect
)

replace github.com/solher/entitycache => github.com/justwatch/entitycache v0.0.0-20240229045341-55dfa11564a7