Skip to content

p-interface: Fix try_from for TokenInstruction #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LStan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

p-interface: Fix try_from for TokenInstruction #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ jobs:
- name: Lint
run: pnpm programs:lint

format_and_lint_pinterface:
name: Format & Lint P-Interface
format_lint_and_test_pinterface:
name: Format, Lint & Test P-Interface
runs-on: ubuntu-latest
steps:
- name: Git Checkout
Expand All @@ -80,6 +80,9 @@ jobs:
- name: Lint
run: pnpm p-interface:lint

- name: Test
run: pnpm p-interface:test

format_and_lint_ptoken:
name: Format & Lint p-token
runs-on: ubuntu-latest
Expand All @@ -99,7 +102,7 @@ jobs:
- name: Lint
run: pnpm p-token:lint

format_and_lint_interface:
format_lint_and_test_interface:
name: Format, Lint & Test Interface
runs-on: ubuntu-latest
steps:
Expand All @@ -118,7 +121,7 @@ jobs:
- name: Lint
run: pnpm interface:lint

- name: Lint
- name: Test
run: pnpm interface:test

audit_rust:
Expand Down Expand Up @@ -214,7 +217,7 @@ jobs:
build_ptoken:
name: Build p-token
runs-on: ubuntu-latest
needs: [format_and_lint_pinterface, format_and_lint_ptoken]
needs: [format_lint_and_test_pinterface, format_and_lint_ptoken]
steps:
- name: Git Checkout
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"fixtures:run": "zx ./scripts/rust/fixtures.mjs run",
"p-interface:format": "zx ./scripts/rust/format.mjs pinocchio/interface",
"p-interface:lint": "zx ./scripts/rust/lint.mjs pinocchio/interface",
"p-interface:test": "zx ./scripts/rust/test.mjs pinocchio/interface",
"interface:format": "zx ./scripts/rust/format.mjs interface",
"interface:lint": "zx ./scripts/rust/lint.mjs interface",
"interface:test": "zx ./scripts/rust/test.mjs interface"
Expand Down
2 changes: 1 addition & 1 deletion pinocchio/interface/src/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ impl TryFrom<u8> for TokenInstruction {
fn try_from(value: u8) -> Result<Self, Self::Error> {
match value {
// SAFETY: `value` is guaranteed to be in the range of the enum variants.
0..=24 | 38 | 255 => Ok(unsafe { core::mem::transmute::<u8, TokenInstruction>(value) }),
0..=24 | 38 | 45 | 255 => Ok(unsafe { core::mem::transmute::<u8, TokenInstruction>(value) }),
_ => Err(TokenError::InvalidInstruction.into()),
}
}
Expand Down