feat: Add methods for checked arithmetics to StakeHistoryEntry#394
Merged
Conversation
The usage of existing `std::ops::Add` implementation triggers the `arithmetic_side_effects` clippy lint. To allow addressing it, add the following methods to `StakeHistoryEntry`: * `checked_add` * `wrapping_add` * `saturating_add`
joncinque
approved these changes
May 20, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Makes sense to me! We might want to consider deprecating the normal ops::Add implementation then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of existing
std::ops::Addimplementation triggers thearithmetic_side_effectsclippy lint.To allow addressing it, add the following methods to
StakeHistoryEntry:checked_addwrapping_addsaturating_add