update program and cli to sdk 3.0 #407
Draft
+3,679
−3,981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
sdk-3.0
branch
2 times, most recently
from
f17e7b9 to
55acb74
Compare
2501babe
commented
Nov 6, 2025
Comment on lines
10
to
+13
| [features] | ||
| no-entrypoint = [] | ||
| custom-heap = [] | ||
| custom-panic = [] |
Member
Author
There was a problem hiding this comment.
someone on stack exchange claims you dont need this to silence warnings on the latest solana-program-entrypoint but we are on latest so i dont think thats true
Member
Author
|
since i opened this different sdk packages depend on different versions of solana-hash which depend on different versions of serde now... its not a priority so ill wait a week or two assuming this is transitory |
2501babe
commented
Dec 24, 2025
Comment on lines
252
to
257
| match u32::from_le_bytes(state_variant) { | ||
| 1 | 2 => Ok(()), | ||
| 1 | 2 | 3 => Ok(()), | ||
| 0 => Err(SinglePoolError::LegacyVoteAccount.into()), | ||
| _ => Err(SinglePoolError::UnparseableVoteAccount.into()), | ||
| } |
Member
Author
There was a problem hiding this comment.
this gives us VoteStateV4 support, it was necessary to do in this pr to get tests to pass. in the future it would be cleaner to switch to the VoteState parser though, which did not exist when this program was originally written. i didnt want to make any nontrivial functional changes in this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo upgrade)spl-token,spl-associated-token-account, andspl-associated-token-account-clientin the program with interface cratesthe diff is large but this has mostly trivial code changes, namely: swapping to token/ata interfaces, changing
VoteStatetoVoteStateV4, changing some import paths, and inlining some format args because clippy wants this now. the only notable change is the addition ofVoteStateV4support to the programi confess to carefully choosing a nightly version that avoids the
this call to clone can be replaced with std::slice::from_refclippy warning, as i didnt want to further overladen the diffthis is (no longer) blocked by:
approve svsp 3.0.0 deployment on mainnetland interface: include onramp in deposit/withdraw #396svsp patch and cli major releasescloses #397
closes #406