build: modernise to use vite #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am looking into the build failures on Netlify |
aalemayhu
force-pushed
the
build/use-vite
branch
from
a457ad4 to
c6fa54e
Compare
aalemayhu
force-pushed
the
build/use-vite
branch
from
135fc48 to
5de807d
Compare
aalemayhu
commented
Jul 20, 2025
| <script src="/vendor/jquery.min.js"></script> | ||
| <script src="/vendor/materialize.min.js"></script> | ||
| <script type="module" src="/src/conferences-page.js"></script> | ||
| </body> |
Contributor
Author
There was a problem hiding this comment.
The script produced by vite needs the type to be module and also the path changes
aalemayhu
force-pushed
the
build/use-vite
branch
from
5de807d to
aecb2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to run on windows and will work with the others.