Migrate StyleSheet.absoluteFillObject#4028
Closed
jenskuhrjorgensen wants to merge 8 commits intosoftware-mansion:mainfrom
Closed
Migrate StyleSheet.absoluteFillObject#4028jenskuhrjorgensen wants to merge 8 commits intosoftware-mansion:mainfrom
jenskuhrjorgensen wants to merge 8 commits intosoftware-mansion:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates all usages of StyleSheet.absoluteFillObject to StyleSheet.absoluteFill, as absoluteFillObject has been removed in React Native 0.85. Both APIs exported the same underlying object, so this is a safe drop-in replacement.
Changes:
- Replace
StyleSheet.absoluteFillObjectwithStyleSheet.absoluteFillacross library source files and example/app files.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx | Migrated two usages in leftActions and rightActions styles |
| packages/react-native-gesture-handler/src/components/ReanimatedDrawerLayout.tsx | Migrated four usages in drawer/container/overlay styles |
| apps/common-app/src/new_api/showcase/bottom_sheet/index.tsx | Migrated one usage in bottomSheet style |
| apps/common-app/src/legacy/v2_api/bottom_sheet/index.tsx | Migrated one usage in bottomSheet style |
| apps/common-app/src/legacy/showcase/bottomSheet/index.tsx | Migrated one usage inline, but missed a second on line 136 |
| apps/common-app/src/legacy/recipes/scaleAndRotate/index.tsx | Migrated one usage in container style |
| apps/common-app/src/legacy/basic/pagerAndDrawer/index.android.tsx | Migrated one usage in page style |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Hi @jenskuhrjorgensen! Thank you for opening this PR! However, it is already part of #4014 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate StyleSheet.absoluteFillObject which has been removed in react-native 0.85: https://github.com/facebook/react-native/releases/tag/v0.85.0-rc.0
Replace removed StyleSheet.absoluteFillObject with StyleSheet.absoluteFill which under the hood exports the exact same object.