Skip to content

Migrate StyleSheet.absoluteFillObject#4028

Closed
jenskuhrjorgensen wants to merge 8 commits intosoftware-mansion:mainfrom
jenskuhrjorgensen:main
Closed

Migrate StyleSheet.absoluteFillObject#4028
jenskuhrjorgensen wants to merge 8 commits intosoftware-mansion:mainfrom
jenskuhrjorgensen:main

Conversation

@jenskuhrjorgensen
Copy link

Description

Migrate StyleSheet.absoluteFillObject which has been removed in react-native 0.85: https://github.com/facebook/react-native/releases/tag/v0.85.0-rc.0

Replace removed StyleSheet.absoluteFillObject with StyleSheet.absoluteFill which under the hood exports the exact same object.

Copilot AI review requested due to automatic review settings March 17, 2026 06:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates all usages of StyleSheet.absoluteFillObject to StyleSheet.absoluteFill, as absoluteFillObject has been removed in React Native 0.85. Both APIs exported the same underlying object, so this is a safe drop-in replacement.

Changes:

  • Replace StyleSheet.absoluteFillObject with StyleSheet.absoluteFill across library source files and example/app files.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx Migrated two usages in leftActions and rightActions styles
packages/react-native-gesture-handler/src/components/ReanimatedDrawerLayout.tsx Migrated four usages in drawer/container/overlay styles
apps/common-app/src/new_api/showcase/bottom_sheet/index.tsx Migrated one usage in bottomSheet style
apps/common-app/src/legacy/v2_api/bottom_sheet/index.tsx Migrated one usage in bottomSheet style
apps/common-app/src/legacy/showcase/bottomSheet/index.tsx Migrated one usage inline, but missed a second on line 136
apps/common-app/src/legacy/recipes/scaleAndRotate/index.tsx Migrated one usage in container style
apps/common-app/src/legacy/basic/pagerAndDrawer/index.android.tsx Migrated one usage in page style

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@m-bert
Copy link
Contributor

m-bert commented Mar 17, 2026

Hi @jenskuhrjorgensen! Thank you for opening this PR! However, it is already part of #4014 😅

@m-bert m-bert closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants