Skip to content

Add Pan offset props to PropsToFilter #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-bert wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Add Pan offset props to PropsToFilter #4026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-native-gesture-handler/src/v3/hooks/utils/propsWhiteList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ export const PropsToFilter = new Set<
'shouldUseReanimatedDetector',
'useAnimated',
'runOnJS',

// Pan offset props before remapping:
'activeOffsetY',
'failOffsetX',
'failOffsetY',
'activeOffsetX',
Comment on lines +81 to +86
Copy link
Contributor Author

@m-bert m-bert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or deleting these keys in transformOffsetProp even when the value is undefined

This is what I said in note in the description of the PR. I'm not sure if we want to do this, but it is an option (cc @j-piasecki)

Copy link
Member

@j-piasecki j-piasecki Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing undefined currently reset the value to the default?

Copy link
Contributor Author

@m-bert m-bert Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you pass undefined it is treated as if it wasn't passed at all.

Copy link
Contributor Author

@m-bert m-bert Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do you mean alternating between some value and undefined?

Copy link
Member

@j-piasecki j-piasecki Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do you mean alternating between some value and undefined?

Yes

]);

export const PropsWhiteLists = new Map<
Expand Down
Loading