Skip to content

[Android] Fix borderless ripple animation #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −3
Open

[Android] Fix borderless ripple animation #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
508dc2d
Fix borderless ripple
j-piasecki Mar 13, 2026
46b7cfa
Update borderless button default config
j-piasecki Mar 13, 2026
3ad3ca2
Update legacy borderless button
j-piasecki Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native-gesture-handler/src/components/GestureButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@
/**
* @deprecated use `BaseButton` instead
*/
export const LegacyBaseButton = React.forwardRef<

Check warning on line 147 in packages/react-native-gesture-handler/src/components/GestureButtons.tsx

View workflow job for this annotation

GitHub Actions / check 

In React 19, 'forwardRef' is no longer necessary. Pass 'ref' as a prop instead
React.ComponentType,
Omit<LegacyBaseButtonProps, 'innerRef'>
>((props, ref) => <InnerBaseButton innerRef={ref} {...props} />);

Check warning on line 150 in packages/react-native-gesture-handler/src/components/GestureButtons.tsx

View workflow job for this annotation

GitHub Actions / check 

Add missing 'displayName' for component

const AnimatedBaseButton = React.forwardRef<

Check warning on line 152 in packages/react-native-gesture-handler/src/components/GestureButtons.tsx

View workflow job for this annotation

GitHub Actions / check 

In React 19, 'forwardRef' is no longer necessary. Pass 'ref' as a prop instead
React.ComponentType,
Animated.AnimatedProps<BaseButtonWithRefProps>
>((props, ref) => <AnimatedInnerBaseButton innerRef={ref} {...props} />);
Expand Down Expand Up @@ -228,6 +228,7 @@
static defaultProps = {
activeOpacity: 0.3,
borderless: true,
foreground: true,
};

private opacity: Animated.Value;
Expand Down
16 changes: 13 additions & 3 deletions packages/react-native-gesture-handler/src/components/GestureHandlerButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ export interface ButtonProps extends ViewProps, AccessibilityProps {
export const ButtonComponent =
RNGestureHandlerButtonNativeComponent as HostComponent<ButtonProps>;

export default function GestureHandlerButton({ style, ...rest }: ButtonProps) {
export default function GestureHandlerButton({
borderless,
style,
...rest
}: ButtonProps) {
const flattenedStyle = useMemo(() => StyleSheet.flatten(style), [style]);

const {
Expand Down Expand Up @@ -222,10 +226,16 @@ export default function GestureHandlerButton({ style, ...rest }: ButtonProps) {
collapsable={false}
style={[
styles.contents,
(!overflow || overflow === 'hidden') && styles.overflowHidden,
!borderless &&
(!overflow || overflow === 'hidden') &&
styles.overflowHidden,
restStyle,
]}>
<ButtonComponent {...rest} style={layoutStyle} />
<ButtonComponent
{...rest}
style={layoutStyle}
borderless={borderless}
/>
</View>
</RNGestureHandlerButtonWrapperNativeComponent>
);
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/src/v3/components/GestureButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ export const BorderlessButton = (props: BorderlessButtonProps) => {

return (
<AnimatedBaseButton
borderless
foreground
{...rest}
onActiveStateChange={onActiveStateChange}
style={[style, Platform.OS === 'ios' && { opacity }]}>
Expand Down
Loading