Conversation
There was a problem hiding this comment.
Pull request overview
This PR documents the new Clickable component in the Gesture Handler 3 docs and updates migration guidance to position Clickable as the unified replacement for legacy/standard button components.
Changes:
- Added a new docs page for
Clickableand updated the upgrading guide/buttons docs to recommend it. - Marked
BaseButton,RectButton, andBorderlessButtonas deprecated in code comments. - Extended
ClickablewithonPressIn/onPressOutcallbacks and wired them into the gesture lifecycle; updated the common app example to log them.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/gesture-handler-3-migration/SKILL.md | Updates migration instructions to recommend Clickable for button migrations. |
| packages/react-native-gesture-handler/src/v3/components/GestureButtons.tsx | Adds @deprecated annotations for standard button components. |
| packages/react-native-gesture-handler/src/v3/components/Clickable/ClickableProps.ts | Adds onPressIn / onPressOut to Clickable’s public props. |
| packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx | Implements onPressIn / onPressOut handling in Clickable. |
| packages/docs-gesture-handler/docs/guides/upgrading-to-3.mdx | Updates upgrade guide “Buttons” section to introduce/recommend Clickable. |
| packages/docs-gesture-handler/docs/components/clickable.mdx | Adds a full Clickable docs page with migration examples and props listing. |
| packages/docs-gesture-handler/docs/components/buttons.mdx | Adds a deprecation warning pointing readers to Clickable. |
| apps/common-app/src/new_api/components/clickable/index.tsx | Updates example usage to include onPressIn / onPressOut. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import HeaderWithBadges from '@site/src/components/HeaderWithBadges'; | ||
|
|
||
| :::danger | ||
| Button components described in this section are deprecated and will be removed in the future. Please use [`Clickable`](/docs/components/clickable) instead. |
There was a problem hiding this comment.
Actually, maybe we would like to keep RawButton? This would keep more flexibility for advanced users. But that's just a thought, not strong opinion - I'm not sure if we want to do that (cc @j-piasecki, @akwasniewski)
Description
This PR adds docs for
ClickablecomponentTest plan
Read docs 🤓