V3 pressable

[akwasniewski]

Description

V3 implementation of pressable component

Test plan

Tested on the following example

import React from 'react';
import { Text, StyleSheet } from 'react-native';
import { Pressable, GestureHandlerRootView } from 'react-native-gesture-handler'

const PressableExample = () => {
  return (
    <GestureHandlerRootView style={styles.container}>
      <Pressable onPressOut={() => console.log("pressed")}
        style={({ pressed }) => [
          {
            backgroundColor: pressed ? 'darkseagreen' : 'seagreen',
          },
          styles.wrapperCustom,
        ]}
      >
        {({ pressed }) => (
          <Text style={styles.text}>
            {pressed ? 'Pressed!' : 'Press Me'}
          </Text>
        )}
      </Pressable>
    </GestureHandlerRootView >
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
  },
  wrapperCustom: {
    borderRadius: 8,
    padding: 16,
    minWidth: 150,
    alignItems: 'center',
  },
  text: {
    fontSize: 18,
    color: 'white',
    fontWeight: '600',
  },
});

export default PressableExample;

[akwasniewski]

Note that I temporarily reverted the broken changes in the shadow node. Without it, the pressable breaks on both android and ios. This change will be reverted before merge.

[j-piasecki]

I don't think the new one should be exported as Legacy (and we probably want to export the legacy one).

[akwasniewski]

Forgot to remove 'v3' from path yesterday 😅. Fixed in ae6e532

[j-piasecki]

The new one is not exported, no?

[akwasniewski]

It is exported, I added it to v3/index and we reexport everything from there.

[m-bert]

Previously in Pressable we had:

  for (const gesture of gestures) {
    gesture.enabled(isPressableEnabled);
    gesture.runOnJS(true);
    gesture.hitSlop(appliedHitSlop);

    Object.entries(relationProps).forEach(([relationName, relation]) => {
      applyRelationProp(
        gesture,
        relationName as RelationPropName,
        relation as RelationPropType
      );
    });
  }

don't new gestures miss enabled and hitSlop?

Also, I don't really like that a lot of code is duplicated. I know that splitting Pressable component may not be worth it, but I don't think it makes sense to duplicate things such as StateMachine (cc @j-piasecki).

[m-bert]

Looks good, please make sure that other Pressable examples work before merging.

Note

Some of them may crash at manual activation, it was fixed on main but not yet cherry-picked to next