Skip to content

chore: Fix bounding box annotation#982

Open
msluszniak wants to merge 2 commits intomainfrom
@ms/make-bounding-boxes-correct
Open

chore: Fix bounding box annotation#982
msluszniak wants to merge 2 commits intomainfrom
@ms/make-bounding-boxes-correct

Conversation

@msluszniak
Copy link
Member

@msluszniak msluszniak commented Mar 18, 2026

Description

This PR fixes the problem in demo apps where bounding boxes were utilized. For small objects annotation width was set to width of the bounding box since they were in the same view. Fix is to make these two be in relation child - parent components.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

  • Compare result of annotation for apps that utilizes bounding boxes for small detected objects.

Screenshots

Now bounding boxes on small objects looks correct (in the #975 was the original result for the same image):
image

Related issues

Closes #975

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak self-assigned this Mar 18, 2026
@msluszniak msluszniak added chore PRs that are chores demo app labels Mar 18, 2026
@msluszniak
Copy link
Member Author

msluszniak commented Mar 19, 2026

TODO: Unify this with with bounding boxes from vision camera so all bounding boxes will be in different colors plus apply these changes to examples from vision camera.
DONE

@msluszniak msluszniak marked this pull request as draft March 19, 2026 09:42
@msluszniak msluszniak marked this pull request as ready for review March 19, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that are chores demo app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make bounding boxes coherent across demo apps

1 participant