Skip to content

Conversation

@msluszniak
Copy link
Member

@msluszniak msluszniak commented Jan 21, 2026

Description

As in the title & moving section Benchmark on the sidebar up, so the benchmarks will be visible immediately.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak self-assigned this Jan 21, 2026
@msluszniak msluszniak added the chore PRs that are chores label Jan 21, 2026
@msluszniak msluszniak linked an issue Jan 21, 2026 that may be closed by this pull request
@msluszniak msluszniak marked this pull request as draft January 21, 2026 19:28
@msluszniak
Copy link
Member Author

Regarding changing the order of section in documentation. To change the order of sections in sidebar, I needed to change directory names (order is autogenerated based on these names). When I changed names from 04-benchmark to 02-benchmark and other accordingly, there was a problem with the links in markdowns pointing to other markdowns. Is there any way to do it smart?

@msluszniak msluszniak force-pushed the @ms/remove-benchmarks-from-hook-api branch from 0ee6b07 to ef72009 Compare January 22, 2026 11:10
@msluszniak msluszniak marked this pull request as ready for review January 22, 2026 11:11
@msluszniak msluszniak requested a review from IgorSwat January 22, 2026 11:11
@msluszniak msluszniak merged commit 9efd924 into main Jan 22, 2026
3 checks passed
@msluszniak msluszniak deleted the @ms/remove-benchmarks-from-hook-api branch January 22, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that are chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove benchmark information from hook docs

3 participants