Conversation
pkaramon
force-pushed
the
@pkaramon/web-setup
branch
from
959e349 to
a3444c5
Compare
…tProps per platform
pkaramon
force-pushed
the
@pkaramon/web-setup
branch
from
a3444c5 to
c9d4f52
Compare
pkaramon
commented
Mar 18, 2026
| EnrichedTextInputInstance, | ||
| } from '../types'; | ||
|
|
||
| export interface EnrichedTextInputProps extends BaseEnrichedTextInputProps {} |
Collaborator
Author
There was a problem hiding this comment.
I will try to keep the types as close as possible between native and web, but I think we will have to make at least so tiny modifications for example the style?: ViewStyle | TextStyle will need changing on web to CSSProperties.
pkaramon
commented
Mar 18, 2026
Comment on lines
+28
to
+35
| "!src/web", | ||
| "!src/index.tsx", | ||
| "!lib/module/web", | ||
| "!lib/module/index.js", | ||
| "!lib/module/index.js.map", | ||
| "!lib/typescript/src/web", | ||
| "!lib/typescript/src/index.d.ts", | ||
| "!lib/typescript/src/index.d.ts.map", |
Collaborator
Author
There was a problem hiding this comment.
I think it would be a good idea to keep the web code hidden until it's at least semi-functional. @exploIF @kacperzolkiewski curious what do you think?
pkaramon
requested review from
exploIF and
kacperzolkiewski
and removed request for
exploIF and
kacperzolkiewski
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain the motivation for making this change: here are some points to help you:
EnrichedTextInputstub to unblock web integration work.EnrichedTextInputfor the webindex.native.tsxentrypoint for android/ios,index.tsxentrypoint for the webTest Plan
Screenshots / Videos