chore: refactor android native structure, rename codegen spec #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roid-namings # Conflicts: # android/src/main/java/com/swmansion/enriched/textinput/EnrichedTextInputView.kt # android/src/main/java/com/swmansion/enriched/textinput/styles/ListStyles.kt # android/src/main/java/com/swmansion/enriched/textinput/styles/ParagraphStyles.kt # android/src/main/java/com/swmansion/enriched/textinput/styles/ParametrizedStyles.kt # android/src/main/java/com/swmansion/enriched/textinput/utils/EnrichedConstants.kt # android/src/main/java/com/swmansion/enriched/textinput/utils/EnrichedSpannable.kt # android/src/main/java/com/swmansion/enriched/textinput/utils/EnrichedSpannableStringBuilder.kt # android/src/main/java/com/swmansion/enriched/textinput/utils/Utils.kt
…roid-namings # Conflicts: # android/src/main/new_arch/react/renderer/components/ReactNativeEnrichedSpec/conversions.h
# Summary This PR refactor checking if heading `bold` prop changed and adds removing bold spans when `htmlStyle` prop changes that headings` (h4, h5, h6)` gets `bold: true` property ## Test Plan 1. Add h5 heading with `bold: false` inside htmlStyle in h5 prop 2. type some text in it with bold style toggled 3. inside htmlStyle in h5 prop change bold to true 4. See that generated html does not contain <b></b> tag ## Screenshots / Videos https://github.com/user-attachments/assets/b861530f-d19f-42f6-a2c7-a77154d4e6f0 ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ❌ | | Android | ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ReactNativeEnrichedSpec- previous naming was fine forinputonly library, but as we plan to bringtextcomponent we should use something more generic.Test Plan
Ensure that library still works fine and there is no regression. This PR should not affect how library works.
Screenshots / Videos
n/a
Compatibility